Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: changed rollup to tsup to simplify bundling #73

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix!: changed rollup to tsup to simplify bundling #73

merged 3 commits into from
Oct 7, 2024

Conversation

gentlementlegen
Copy link
Member

0x4007
0x4007 reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure esbuild is superior what are you trying to accomplish here

@gentlementlegen
Copy link
Member Author

@0x4007 tsup is literally built on top of esbuild, we use it on most of out projects and it helps with bundling configuration made much simpler.

@gentlementlegen gentlementlegen requested a review from 0x4007 October 7, 2024 03:59
@gentlementlegen
Copy link
Member Author

https://github.com/egoist/tsup?tab=readme-ov-file#tsup

Needed to work within ESM projects as files were not compiled properly.

@gentlementlegen gentlementlegen mentioned this pull request Oct 7, 2024
Merged
0x4007
0x4007 reviewed Oct 7, 2024
View reviewed changes
tsup.config.ts Show resolved Hide resolved
tsup.config.ts Outdated Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Oct 7, 2024

You can merge after you make a decision on my review comment

@gentlementlegen gentlementlegen merged commit e2ea327 into ubiquity-os:development Oct 7, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/tsup branch October 7, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gentlementlegen @0x4007