Feat: PR#69 adjustments #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: test
0x4007
reviewed
Oct 8, 2024
Comment on lines
+20
to
+21
| process.env["NFT_MINTER_PRIVATE_KEY"] = ""; | ||
| process.env["NFT_CONTRACT_ADDRESS"] = ""; |
There was a problem hiding this comment.
Hey, I think this could be useful here if, down the road, someone needs to generate ERC721 tokens using this GitHub action. But for now, we can either stick with this approach or introduce a new environment schema, though that would require bigger changes to the codebase due to the type checks. Oh, and by the way, this actually relates to PR#69, not this one. I'll rebase once that PR is merged.
Unused devDependencies (1)
Unresolved imports (10)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80