-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update index #1038
feat: update index #1038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine @rndquu what do you think is the easiest way we can test that this works?
@BeanieMen do you have any evidence to prove that this works as expected?
Can I wait to see what rndquu says about testing |
/wallet 0x24fbA1343132DE969Aeef0B1BD5CaAE1fB102978 |
+ Successfully registered wallet address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BeanieMen Pls:
- Fix the issues in comments
- Provide a QA (links to 3 issues) for 3 cases described in the original issue Hide unavailable bounties devpool-directory-tasks#11
it shows i was the one who did the actions, i used my GITHUB_TOKEN because i ran the script using tsx |
yay it finally works. |
/query @BeanieMen |
|
I have just queried @BeanieMen to check if the correct wallet was assigned, somehow it is broken for my wallet only.. |
/query @gitcoindev |
|
will qa after rndquu gives his opinion about this |
@pavlovcik please tell me why you are not reviewing ubiquity/.github#90 |
2c0f29d
to
4bed67a
Compare
@rndquu the logic should still be the same as the cases where project issue is open is already handled and when it is closed, devpool issue should be closed regardless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember here was a check that if project issue is assigned then don't sync such bounty with devpool. Not sure why this check was removed.
Right now if project issue is open and assigned (and does not exist in devpool) then such issue will be synced while the desired behaviour is to skip already assigned issues in partner projects.
Weird, I remember leaving that check as is |
@rndquu can you review this also? |
@BeanieMen Still not implemented |
Damn I give up, I can't figure this out |
Resolves #11