Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update index #1038

Closed
wants to merge 1 commit into from
Closed

Conversation

BeanieMen
Copy link
Contributor

Resolves #11

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine @rndquu what do you think is the easiest way we can test that this works?

@BeanieMen do you have any evidence to prove that this works as expected?

@BeanieMen
Copy link
Contributor Author

Code looks fine @rndquu what do you think is the easiest way we can test that this works?

@BeanieMen do you have any evidence to prove that this works as expected?

Can I wait to see what rndquu says about testing

@BeanieMen
Copy link
Contributor Author

/wallet 0x24fbA1343132DE969Aeef0B1BD5CaAE1fB102978

Copy link
Contributor

ubiquibot bot commented Feb 2, 2024

+ Successfully registered wallet address

@0x4007 0x4007 requested a review from rndquu February 2, 2024 10:25
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BeanieMen Pls:

  1. Fix the issues in comments
  2. Provide a QA (links to 3 issues) for 3 cases described in the original issue Hide unavailable bounties devpool-directory-tasks#11

index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
@BeanieMen
Copy link
Contributor Author

case 1 This wasnt synced
case 2 this closed because it was unavailable
case 3 this reopened even tho i closed it

@BeanieMen
Copy link
Contributor Author

it shows i was the one who did the actions, i used my GITHUB_TOKEN because i ran the script using tsx

@BeanieMen BeanieMen requested a review from rndquu February 3, 2024 06:56
@BeanieMen BeanieMen marked this pull request as draft February 3, 2024 11:55
@BeanieMen
Copy link
Contributor Author

yay it finally works.

@BeanieMen BeanieMen marked this pull request as ready for review February 4, 2024 05:18
@BeanieMen
Copy link
Contributor Author

case 1 was never synced
case 2 was closed automatically because it was unavailable
case 3 the opened automatically because it was available and closed

index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Show resolved Hide resolved
@gitcoindev
Copy link
Contributor

/query @BeanieMen

Copy link
Contributor

ubiquibot bot commented Feb 6, 2024

Property Value
Wallet 0x24fbA1343132DE969Aeef0B1BD5CaAE1fB102978

@gitcoindev
Copy link
Contributor

I have just queried @BeanieMen to check if the correct wallet was assigned, somehow it is broken for my wallet only..

@BeanieMen
Copy link
Contributor Author

/query @gitcoindev

Copy link
Contributor

ubiquibot bot commented Feb 6, 2024

Property Value
Wallet 0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4

@BeanieMen
Copy link
Contributor Author

that wouldnt work because if a open project issue has a assignee, it should be closed in the devpool but after closing the issue in the devpool, that check opened the issue.

will qa after rndquu gives his opinion about this

index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
@BeanieMen
Copy link
Contributor Author

case 1 was never synced
case 2 this closed because it was unavailable
case 3 this reopened even tho i closed it

@BeanieMen BeanieMen requested a review from rndquu February 8, 2024 10:06
@BeanieMen
Copy link
Contributor Author

@pavlovcik please tell me why you are not reviewing ubiquity/.github#90
its been more than 2 whole weeks

index.ts Outdated Show resolved Hide resolved
@BeanieMen
Copy link
Contributor Author

A closed issue is being display in work.ubq.fi Screenshot_2024-02-10-11-25-03-68_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

@BeanieMen
Copy link
Contributor Author

@rndquu the logic should still be the same as the cases where project issue is open is already handled and when it is closed, devpool issue should be closed regardless

@BeanieMen BeanieMen requested a review from rndquu February 16, 2024 11:02
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember here was a check that if project issue is assigned then don't sync such bounty with devpool. Not sure why this check was removed.

Right now if project issue is open and assigned (and does not exist in devpool) then such issue will be synced while the desired behaviour is to skip already assigned issues in partner projects.

@BeanieMen
Copy link
Contributor Author

Weird, I remember leaving that check as is

@BeanieMen BeanieMen requested a review from rndquu February 22, 2024 05:28
@BeanieMen
Copy link
Contributor Author

@rndquu can you review this also?

@rndquu
Copy link
Member

rndquu commented Feb 27, 2024

I remember here was a check that if project issue is assigned then don't sync such bounty with devpool. Not sure why this check was removed.

Right now if project issue is open and assigned (and does not exist in devpool) then such issue will be synced while the desired behaviour is to skip already assigned issues in partner projects.

@BeanieMen Still not implemented

@BeanieMen
Copy link
Contributor Author

Damn I give up, I can't figure this out

@rndquu rndquu closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide unavailable bounties
4 participants