Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide unavailable bounties #1102

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Mar 3, 2024

Resolves ubiquity/devpool-directory-tasks#11

I'm currently assigned the dynamic rpc handler task so in my forked devpool repo it's closed

@0x4007 0x4007 requested a review from rndquu March 5, 2024 06:56
@0x4007
Copy link
Member

0x4007 commented Mar 5, 2024

@Keyrxng as a heads up I'm sort of stepping away from code reviews these days, so that I can spend more time on recruiting and fundraising. In the short term I plan to just stay on top of conversations at a high level in order to remedy any operational blockers during this transition phase.

In this situation I think you should request for reviews until we figure out who will be the de-facto "manager" of this repository, although I would default to rndquu if I'm not sure for most cases.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Mar 5, 2024

I hope that's a good thing for you but cheers mate I'll ping rndquu or paul from now on

Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, when this PR is merged we're free to remove the "Unavailable label" feature since all of the open issues in the devpool will be available for self-assignment

index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Mar 7, 2024

total-rewards.txt Outdated Show resolved Hide resolved
@rndquu
Copy link
Member

rndquu commented Mar 10, 2024

@Keyrxng Pls notice that requested changes are not implemented

@rndquu rndquu marked this pull request as draft March 10, 2024 09:29
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Mar 10, 2024

@Keyrxng Pls notice that requested changes are not implemented

I was thinking wth I did make the changes, but after checking I realize I forgot to push lmao

@rndquu rndquu self-requested a review March 11, 2024 07:17
@rndquu rndquu marked this pull request as ready for review March 11, 2024 07:17
index.ts Outdated Show resolved Hide resolved
@rndquu rndquu self-requested a review March 13, 2024 07:31
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@rndquu rndquu merged commit 970b4e1 into ubiquity:development Mar 13, 2024
2 checks passed
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Mar 13, 2024

@rndquu should the checks against the unavailable labels be removed? I think that's what's causing the open/close cycle that's happening right now.

Looking at the logs

second most recent run:

Closed (assigned): https://github.com/ubiquity/devpool-directory/issues/1125 (https://github.com/ubiquity/pay.ubq.fi/issues/196)

most recent run:

Updated: https://github.com/ubiquity/devpool-directory/issues/1125 (https://github.com/ubiquity/pay.ubq.fi/issues/196)

with "Updated: ..." it's happening outside of the two conditionals I added, and you said that there's no need to check those labels and they'll be getting removed anyway?

@0x4007
Copy link
Member

0x4007 commented Mar 14, 2024

@Keyrxng test on your fork then to prove that its a solution. I would consider this problem urgent because it negatively affects new people coming to work.ubq.fi to see if they want to work with us.

@rndquu
Copy link
Member

rndquu commented Mar 14, 2024

@rndquu should the checks against the unavailable labels be removed?

Yes

with "Updated: ..." it's happening outside of the two conditionals I added, and you said that there's no need to check those labels and they'll be getting removed anyway?

Yes

Related issue ubiquity/devpool-directory-tasks#22

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Mar 14, 2024

Only just seeing this now, my notifications got tanked after I chose only the day before yesterday to subscribe to devpool notifications lmao. I'll test it before pushing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide unavailable bounties
3 participants