chore: fix knip warnings in onboarding repository #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set correct entry points in knip.ts for onboarding repostiory to find all dependencies * add unlisted transitive dependencies to package.json that were imported directly * add no-unused-vars to two unused exports
Unused dependencies (2)
|
|
@rndquu this should fix the Knip configuration and #14 should be also passing aftwards. I also got the comment above about @supabase/supabase-js and @ubiquibot/configuration in my fork when I did QA, after merging it will disappear. I am going to fix all Knip configurations this week, if you know any other repository that needs the configuration change please let me know. |
rndquu
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18
QA: merged to fork and tested at gitcoindev#4
Also tested against local workspace: