Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move other apps to separate repo #171

Closed
0x4007 opened this issue Feb 21, 2024 · 23 comments · Fixed by ubiquity/audit.ubq.fi#1, ubiquity/keygen.ubq.fi#1 or ubiquity/onboard.ubq.fi#1

Comments

@0x4007
Copy link
Member

0x4007 commented Feb 21, 2024

Let's keep this repo focused only on the main app which is pay.ubq.fi

The other apps like audits, and onboarding, should be moved to a separate repository.

This should keep the codebase smaller and more manageable.

@molecula451
Copy link
Member

The other apps like audits, and onboarding, should be moved to a separate repository.

creating a new repo?

@0x4007
Copy link
Member Author

0x4007 commented Feb 28, 2024

Audits should be like audit.ubq.fi and onboarding should be like onboard.ubq.fi or something like that, yes. Separate repositories started from ts-template.

@molecula451
Copy link
Member

molecula451 commented Feb 29, 2024

Let's gradually achieve this

pavlovick

Live Video preview test : https://www.dropbox.com/scl/fi/l2cky9gi8yv9wishb8ipx/audit.ubq.fi.webm?rlkey=rnpovfjr373yvd0y6ovp0ba2q&dl=0

check the repo! out, need to debug a few other things (& purge things from the original template), but after good stage, then we clone this repo to main ubiquity organization, no need to fork, etc

@molecula451
Copy link
Member

molecula451 commented Feb 29, 2024

audit.ubq.fi is done! please clone, build & start special thanks to @rndquu for test data we highlight yet again the importance of good comments

Further

pavlovcik, rndquu please clone, yarn and start the UI, test so we move this to Audit repo

test live preview above: #171 (comment)

I'm creating a branch to Audit repo to then PR the changes to "development" or any other default branch for further code review, enhancement

lastly i will PR to this repo pay.ubq.fi to purge anything relates to audit

@molecula451 molecula451 linked a pull request Mar 1, 2024 that will close this issue
@molecula451
Copy link
Member

molecula451 commented Mar 1, 2024

Can be merge after all the refactors are done

ubiquity/audit.ubq.fi#1
ubiquity/keygen.ubq.fi#1

Copy link

ubiquibot bot commented Mar 1, 2024

+ Evaluating results. Please wait...

@rndquu
Copy link
Member

rndquu commented Mar 1, 2024

Can be merge after all the refactors are done

ubiquity/audit.ubq.fi#1 ubiquity/keygen.ubq.fi#1

We should also remove both audit and keygen pages from https://github.com/ubiquity/pay.ubq.fi

Copy link

ubiquibot bot commented Mar 1, 2024

[ 14 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification17.8
IssueComment16.2
Conversation Incentives
CommentFormattingRelevanceReward
Let's keep this repo focused only on the main app which is pay.u...
7.817.8
Audits should be like audit.ubq.fi and onboarding should be like...
6.2
code:
  count: 1
  score: "1"
  words: 2
0.526.2

[ 32.2 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueComment432.2
Conversation Incentives
CommentFormattingRelevanceReward
> The other apps like audits, and onboarding, should be moved to...
0.40.7950.4
### Let's gradually achieve this

pavlovick

  • audit.ubq.fi
    h...
11.4
h3:
  count: 1
  score: "1"
  words: 5
a:
  count: 1
  score: "1"
  words: 1
li:
  count: 1
  score: "1"
  words: 0
0.7911.4
[audit.ubq.fi](https://github.com/molecula451/audit.ubq.fi) is d...
16.7
h2:
  count: 1
  score: "1"
  words: 1
a:
  count: 5
  score: "5"
  words: 9
code:
  count: 1
  score: "1"
  words: 3
0.75516.7
### Can be merge after all the refactors are done

https://git...

3.7

h3:
  count: 1
  score: "1"
  words: 9
0.753.7

[ 6.7 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueComment16.7
Conversation Incentives
CommentFormattingRelevanceReward
> ### Can be merge after all the refactors are done > [ubiquity...
6.7
h3:
  count: 1
  score: "1"
  words: 9
a:
  count: 2
  score: "2"
  words: 10
code:
  count: 2
  score: "2"
  words: 2
0.86.7

@0x4007
Copy link
Member Author

0x4007 commented Mar 1, 2024

Oh I guess I wasn't supposed to merge it yet. Perhaps we should wait until they are all merged and then close this issue and claim the rewards? @molecula451

@molecula451
Copy link
Member

We should also remove both audit and keygen pages from https://github.com/ubiquity/pay.ubq.fi

of course

@molecula451
Copy link
Member

Oh I guess I wasn't supposed to merge it yet. Perhaps we should wait until they are all merged and then close this issue and claim the rewards? @molecula451

yes

@molecula451 molecula451 reopened this Mar 1, 2024
@molecula451
Copy link
Member

closing & re-opening was expected at least on my end

@0x4007
Copy link
Member Author

0x4007 commented Mar 1, 2024

Looks like I probably underestimated the time

@molecula451
Copy link
Member

mergin: ubiquity/keygen.ubq.fi#1 expect close & re-open

This comment was marked as duplicate.

This comment was marked as duplicate.

@molecula451
Copy link
Member

/start

Copy link

ubiquibot bot commented Mar 2, 2024

DeadlineSun, Mar 3, 6:21 PM UTC
Registered Wallet 0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@molecula451
Copy link
Member

good to close

This comment was marked as duplicate.

@molecula451 molecula451 reopened this Mar 4, 2024
@molecula451
Copy link
Member

molecula451 commented Mar 4, 2024

pavlovcik i think you can close, @rndquu i think you can close too, so people focus on the new apps

@0x4007 0x4007 closed this as completed Mar 4, 2024
Copy link

ubiquibot bot commented Mar 4, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Mar 4, 2024

[ 21.4 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification17.8
IssueComment313.6
Conversation Incentives
CommentFormattingRelevanceReward
Let's keep this repo focused only on the main app which is pay.u...
7.817.8
Audits should be like audit.ubq.fi and onboarding should be like...
6.2
code:
  count: 1
  score: "1"
  words: 2
0.456.2
Oh I guess I wasn't supposed to merge it yet. Perhaps we should ...
60.6756
Looks like I probably underestimated the time...
1.40.531.4

[ 439.2 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueTask1400
IssueComment100
IssueComment1039.2
Conversation Incentives
CommentFormattingRelevanceReward
> The other apps like audits, and onboarding, should be moved to...
-0.66-
### Let's gradually achieve this

pavlovick

  • audit.ubq.fi
    h...
-
h3:
  count: 1
  score: "0"
  words: 5
a:
  count: 1
  score: "0"
  words: 1
li:
  count: 1
  score: "0"
  words: 0
0.81-
[audit.ubq.fi](https://github.com/molecula451/audit.ubq.fi) is d...
-
h2:
  count: 1
  score: "0"
  words: 1
a:
  count: 5
  score: "0"
  words: 9
code:
  count: 1
  score: "0"
  words: 3
0.795-
### Can be merge after all the refactors are done

https://git...

-

h3:
  count: 1
  score: "0"
  words: 9
0.585-
> We should also remove both `audit` and `keygen` pages from htt...
-
code:
  count: 2
  score: "0"
  words: 2
0.62-
> Oh I guess I wasn't supposed to merge it yet. Perhaps we shoul...
-0.635-
closing & re-opening was expected at least on my end...
-0.56-
mergin: https://github.com/ubiquity/keygen.ubq.fi/pull/1 expect ...
-0.59-
good to close...
-0.54-
pavlovcik i think you can close, @rndquu i think you can close t...
-0.59-
> The other apps like audits, and onboarding, should be moved to...
0.40.660.4
### Let's gradually achieve this

pavlovick

  • audit.ubq.fi
    h...
11.4
h3:
  count: 1
  score: "1"
  words: 5
a:
  count: 1
  score: "1"
  words: 1
li:
  count: 1
  score: "1"
  words: 0
0.8111.4
[audit.ubq.fi](https://github.com/molecula451/audit.ubq.fi) is d...
16.7
h2:
  count: 1
  score: "1"
  words: 1
a:
  count: 5
  score: "5"
  words: 9
code:
  count: 1
  score: "1"
  words: 3
0.79516.7
### Can be merge after all the refactors are done

https://git...

3.7

h3:
  count: 1
  score: "1"
  words: 9
0.5853.7
> We should also remove both `audit` and `keygen` pages from htt...
2.2
code:
  count: 2
  score: "2"
  words: 2
0.622.2
> Oh I guess I wasn't supposed to merge it yet. Perhaps we shoul...
0.10.6350.1
closing & re-opening was expected at least on my end...
10.561
mergin: https://github.com/ubiquity/keygen.ubq.fi/pull/1 expect ...
1.40.591.4
good to close...
0.30.540.3
pavlovcik i think you can close, @rndquu i think you can close t...
20.592

[ 6.7 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueComment16.7
Conversation Incentives
CommentFormattingRelevanceReward
> ### Can be merge after all the refactors are done > [ubiquity...
6.7
h3:
  count: 1
  score: "1"
  words: 9
a:
  count: 2
  score: "2"
  words: 10
code:
  count: 2
  score: "2"
  words: 2
0.66.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment