Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: initial stage audit.ubq.fi #1

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Refactor: initial stage audit.ubq.fi #1

merged 6 commits into from
Mar 1, 2024

Conversation

molecula451
Copy link
Member

Resolves #171

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Unused dependencies (7)

Filename dependencies
package.json @octokit/plugin-throttling
@octokit/rest
@sinclair/typebox
@supabase/supabase-js
axios
ethers
godb

Unused devDependencies (2)

Filename devDependencies
package.json eslint-config-prettier
eslint-plugin-prettier

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 1, 2024 •
edited
Loading

@molecula451 molecula451 mentioned this pull request Mar 1, 2024
Closed
@molecula451 molecula451 changed the title Refactor: Develop molecula pr Refactor: audit.ubq.fi Mar 1, 2024
@molecula451 molecula451 marked this pull request as ready for review March 1, 2024 02:31
@molecula451 molecula451 changed the title Refactor: audit.ubq.fi Refactor: initial stage audit.ubq.fi Mar 1, 2024
@molecula451 molecula451 marked this pull request as draft March 1, 2024 02:37
@molecula451 molecula451 marked this pull request as ready for review March 1, 2024 02:50
@molecula451 molecula451 linked an issue Mar 1, 2024 that may be closed by this pull request
Refactor: move other apps to separate repo ubiquity/pay.ubq.fi#171
Closed
0x4007
0x4007 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed CI and deploy link looks fine.

gentlementlegen
gentlementlegen approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@gentlementlegen gentlementlegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the changes too. Will just complain about the commit messages and the lack of tests.

@molecula451
Copy link
Member Author

Will just complain about the commit messages

Taking that in count

and the lack of tests.

good for new upcoming issues

@0x4007 0x4007 merged commit 8f0230c into development Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu approved these changes

@gentlementlegen gentlementlegen gentlementlegen approved these changes

@0x4007 0x4007 0x4007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: move other apps to separate repo
4 participants
@molecula451 @0x4007 @gentlementlegen @rndquu