Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display all permitted issues in audit #140

Merged

Conversation

gitcoindev
Copy link
Contributor

Fix an early exit from the comment analysis loop and a special case, where the claim permit for the same bounty was generated twice. The audit tool stopped and pointed at the first, wrong permit.

Resolves: #126

QA:
image

Fix an early exit from the comment analysis loop and a special case,
where the claim permit for the same bounty was generated twice.
The audit tool stopped and pointed at the first, wrong permit.

Resolves: ubiquity#126
@gitcoindev gitcoindev requested a review from 0x4007 as a code owner October 11, 2023 21:52
@rndquu rndquu self-requested a review October 12, 2023 06:41
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bounty hunter column is undefined for some of the issues while assignee is set in those issues, pls fix.
Screenshot 2023-10-12 at 10 09 15

@gitcoindev
Copy link
Contributor Author

Bounty hunter column is undefined for some of the issues while assignee is set in those issues, pls fix. Screenshot 2023-10-12 at 10 09 15

Hi @rndquu , solved in last commit.

QA:

image

@gitcoindev gitcoindev requested a review from rndquu October 12, 2023 07:48
@ubiquibot
Copy link

ubiquibot bot commented Oct 12, 2023

Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@rndquu rndquu merged commit 037830a into ubiquity:development Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit dApp: not all issues are displayed
2 participants