Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Fetch Fastest RPC For Rewards dApp #150

Closed
wants to merge 5 commits into from
Closed

Feature: Fetch Fastest RPC For Rewards dApp #150

wants to merge 5 commits into from

Conversation

barebind
Copy link
Contributor

@barebind barebind commented Feb 7, 2024

Resolves #130

  • Using integers instead of hexes for networkId/chainId is less confusing and also is compatible with specs.
  • Fixed some missing parts/fields for scripts/typescript/generate-permit2-url.ts
  • network parameter in the url is not used so I removed it. networkId fromClaimTx is used instead.
  • More structured multi-chain network config might be a better use.
  • onboarding has it's own switchNetwork functions etc. Some functions are shared across different UIs and some are not. Definitely confusing for newcomers.
  • isNonceClaimed always returns true for a new setup(new ubiquibot account) on Goerli. Something must be missing in the documentation. Don't know what and why.
  • For getOptimalRpc() functionality. The current approach is definitely not the best one as it always calls whenever it needs rpc provider. There must be some context to store optimal provider and fetching optimal RPC must be on page load or something.
  • Optimal RPC as a concept cannot be applied to Metamask because if an already added network has a slow rpc provider on Metamask side, there is no edit option as far as I know. So using optimal RPC provider is for only backend calls like transaction data rendering, fetching nonces etc. but sending a transaction through Metamask is via it's own stored rpc provider for chainId.

Copy link

ubiquibot bot commented Feb 7, 2024

@barebind barebind closed this by deleting the head repository Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Fastest RPC For Rewards dApp
2 participants