Feature: Fetch Fastest RPC For Rewards dApp #150
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130
networkId
/chainId
is less confusing and also is compatible with specs.scripts/typescript/generate-permit2-url.ts
network
parameter in the url is not used so I removed it.networkId
fromClaimTx
is used instead.onboarding
has it's own switchNetwork functions etc. Some functions are shared across different UIs and some are not. Definitely confusing for newcomers.isNonceClaimed
always returns true for a new setup(new ubiquibot account) on Goerli. Something must be missing in the documentation. Don't know what and why.getOptimalRpc()
functionality. The current approach is definitely not the best one as it always calls whenever it needs rpc provider. There must be some context to store optimal provider and fetching optimal RPC must be on page load or something.