Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/knip #202

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Fix/knip #202

merged 6 commits into from
Mar 20, 2024

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Mar 15, 2024

  • Add knip config
  • Run knip

@0x4007 0x4007 mentioned this pull request Mar 15, 2024
Merged
@0x4007
Copy link
Member Author

0x4007 commented Mar 15, 2024

@rndquu do you know about the jq error for Cloudflare deploys? https://github.com/ubiquity/pay.ubq.fi/actions/runs/8290896466/job/22689684723?pr=202#step:5:29

@rndquu
Copy link
Member

rndquu commented Mar 15, 2024

@rndquu do you know about the jq error for Cloudflare deploys? https://github.com/ubiquity/pay.ubq.fi/actions/runs/8290896466/job/22689684723?pr=202#step:5:29

Yes, I'll fix it today

@0x4007
Copy link
Member Author

0x4007 commented Mar 17, 2024

Let me know when we can test and merge this @rndquu

@rndquu
Copy link
Member

rndquu commented Mar 19, 2024

Let me know when we can test and merge this @rndquu

Merge the latest development branch, cloudflare deploy should work

@0x4007 0x4007 marked this pull request as ready for review March 20, 2024 12:12
@0x4007 0x4007 requested a review from rndquu as a code owner March 20, 2024 12:12
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 20, 2024 •
edited
Loading

@0x4007 0x4007 requested a review from gitcoindev March 20, 2024 12:12
@0x4007 0x4007 merged commit d589f16 into ubiquity:development Mar 20, 2024
3 checks passed
@0x4007 0x4007 deleted the fix/knip branch March 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitcoindev gitcoindev gitcoindev approved these changes

@rndquu rndquu Awaiting requested review from rndquu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x4007 @rndquu @gitcoindev