Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): cspell and eslint fixes #255

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(ci): cspell and eslint fixes #255

merged 1 commit into from
Jul 15, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Jul 13, 2024

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jul 13, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 13, 2024 •
edited
Loading

Preview Deployment
03a6359b0c8369713ca3d6cf3d0169382fde04fb
42df6df3ef608015868130e1b6a7f6c85b2e13da

@Keyrxng Keyrxng requested a review from rndquu July 13, 2024 01:02
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 13, 2024

This is probably one of those ones you'd merge without additional approval rndquu right? I considered it but sticking with one minimum for now even with this type

@rndquu
Copy link
Member

rndquu commented Jul 15, 2024

This is probably one of those ones you'd merge without additional approval rndquu right? I considered it but sticking with one minimum for now even with this type

Yes, I think 1 approval is enough for such kind of PRs

@Keyrxng Keyrxng merged commit 42df6df into ubiquity:development Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keyrxng @rndquu