Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View claim #300

Merged
merged 4 commits into from
Sep 12, 2024
Merged

View claim #300

merged 4 commits into from
Sep 12, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Sep 12, 2024

I added a little delay effect, no autographs please

claim-with-wait.mp4

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Sep 12, 2024

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

I added a little delay effect

I don't understand

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

I added a little delay effect

I don't understand

lol it was a joke, I just added a 3 second promise before showing the success to better simulate the real thing for the sake of QA 😂

@Keyrxng Keyrxng merged commit a06084c into ubiquity:development Sep 12, 2024
3 checks passed
@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

Doesn't work

https://blockscan.com/Error/404

@0x4007 0x4007 mentioned this pull request Sep 12, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

We do indeed get the hash and it doesn't change from it being sent and it being confirmed afaik. So I think either Blockscan doesn't have it yet and returns a 404 or there is some other issue, likely it hadn't populated yet. Idk if you'll agree but explorers tend to hold the tx until it is confirmed, perhaps Blockscan is different.

I will think more on your comment and include this attempted optimization (properly implemented if it's doable) alongside any others. I'll aim to have a PR open for this over the weekend.

Was it the preview deployment that you tested I assume?

Would you be able to share the PK for the wallet used for the preview deployments with me?

image

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

It was merged to production and I claimed and tested. You should run locally and claim/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants