Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand code blocks in preview #155

Closed
zugdev opened this issue Nov 3, 2024 · 16 comments · Fixed by #157
Closed

expand code blocks in preview #155

zugdev opened this issue Nov 3, 2024 · 16 comments · Fixed by #157

Comments

@zugdev
Copy link
Collaborator

zugdev commented Nov 3, 2024

Code blocks in issue previews are currently barely readable, take the image from this preview as an example:

image

On GitHub it looks like this:

image

Which is much more readable.

@0x4007
Copy link
Member

0x4007 commented Nov 3, 2024

It's tricky to do correctly with css but yeah would be nice

Copy link
Contributor

ubiquity-os bot commented Nov 5, 2024

! Please set your wallet address with the /wallet command first and try again.

@dawidsawa
Copy link
Contributor

/wallet 0x2C0494B5C7199ae844c0dF08ba6828075FC462Fc

Copy link
Contributor

ubiquity-os bot commented Nov 5, 2024

+ Successfully registered wallet address

Copy link
Contributor

ubiquity-os bot commented Nov 5, 2024

Deadline Tue, Nov 5, 4:16 PM UTC
Beneficiary 0x2C0494B5C7199ae844c0dF08ba6828075FC462Fc

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@zugdev
Copy link
Collaborator Author

zugdev commented Nov 11, 2024

@gentlementlegen apparently permit generation did not run.

@zugdev
Copy link
Collaborator Author

zugdev commented Nov 11, 2024

This is how it looks now:

image

We could possibly look into a coloring lib in the future.

@gentlementlegen
Copy link
Member

@zugdev got a lot of fetch request that went loose:
image

I will try to regenerate.

Copy link
Contributor

ubiquity-os bot commented Nov 12, 2024

 [ 6 UUSD ] 

@dawidsawa
Contributions Overview
ViewContributionCountReward
IssueTask16
ReviewComment50
Conversation Incentives
CommentFormattingRelevanceReward
Resolves #155
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0
  result: 0
0.70
Before![before](https://github.com/user-attachments/assets/756…
10.36
content:
  content:
    p:
      score: 0
      elementCount: 4
    img:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 2
  wordValue: 0.2
  result: 0.36
0.80
Given the background is already very dark adding even an absolut…
13.19
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 10
regex:
  wordCount: 26
  wordValue: 0.2
  result: 3.19
0.90
How about now:![dark](https://github.com/user-attachments/asse…
10.51
content:
  content:
    p:
      score: 0
      elementCount: 3
    img:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 3
  wordValue: 0.2
  result: 0.51
0.60
EDIT: my bad, that did not fix it.https://a642e753.devpool-dir…
7.22
content:
  content:
    p:
      score: 0
      elementCount: 3
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 17
  wordValue: 0.2
  result: 2.22
0.20

 [ 0.616 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment10.616
Conversation Incentives
CommentFormattingRelevanceReward
It's tricky to do correctly with css but yeah would be nice
0.88
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 13
  wordValue: 0.1
  result: 0.88
0.70.616

 [ 69.0875 UUSD ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueSpecification150.25
IssueComment26.215
ReviewComment412.6225
Conversation Incentives
CommentFormattingRelevanceReward
Code blocks in issue previews are currently barely readable, tak…
16.75
content:
  content:
    p:
      score: 0
      elementCount: 5
    a:
      score: 5
      elementCount: 1
    img:
      score: 5
      elementCount: 2
  result: 15
regex:
  wordCount: 29
  wordValue: 0.1
  result: 1.75
150.25
@gentlementlegen apparently permit generation did not run.
1.05
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0.2
  result: 1.05
0.10.105
This is how it looks now:![image](https://github.com/user-atta…
7.22
content:
  content:
    p:
      score: 0
      elementCount: 3
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 17
  wordValue: 0.2
  result: 2.22
0.56.11
Please add `overflow-x: scroll` in code block, to handle…
11.44
content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 10
regex:
  wordCount: 23
  wordValue: 0.1
  result: 1.44
0.92.824
Please consider the inverted style too because when browser is i…
21.61
content:
  content:
    p:
      score: 0
      elementCount: 5
    img:
      score: 5
      elementCount: 3
    ol:
      score: 1
      elementCount: 2
    li:
      score: 0.5
      elementCount: 2
  result: 18
regex:
  wordCount: 68
  wordValue: 0.1
  result: 3.61
15.4
That's better, one last thing check [this issue](https://de78886…
17.69
content:
  content:
    p:
      score: 0
      elementCount: 5
    a:
      score: 5
      elementCount: 1
    img:
      score: 5
      elementCount: 2
  result: 15
regex:
  wordCount: 48
  wordValue: 0.1
  result: 2.69
0.84.2855
Looks good! Not sure about hard-coded colors tho, @0x4007 RFC
0.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0.1
  result: 0.77
0.60.113

 [ 0.57 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment10.57
Conversation Incentives
CommentFormattingRelevanceReward
@zugdev got a lot of fetch request that went loose:<img wid…
1.9
content:
  content:
    p:
      score: 0
      elementCount: 3
  result: 0
regex:
  wordCount: 32
  wordValue: 0.1
  result: 1.9
0.30.57

@gentlementlegen
Copy link
Member

gentlementlegen commented Nov 12, 2024

It seems we get a lot of errors during runs
image

I am not sure if that's because we start to have too many plugins to call. @0x4007 rfc

@zugdev
Copy link
Collaborator Author

zugdev commented Nov 12, 2024

My reward seems incorrect. @0x4007 if necessary revoke it.

@gentlementlegen
Copy link
Member

gentlementlegen commented Nov 12, 2024

@zugdev as long as you don't claim it we can regenerate it. Seems that there is a high boost on the specification.

So technically your reward is correct, but I remember somewhere we talked about capping it so it doesn't go higher than the reward of the issue itself or something like that (there currently is a x3 boost on the specs so you got 16.75 * 3 = 50.25).

@zugdev
Copy link
Collaborator Author

zugdev commented Nov 12, 2024

It seems we get a lot of errors during runs
image

I am not sure if that's because we start to have too many plugins to call.

I am not an expert in workers but, from my experience with distributed systems, it seems super weird that there isn't a way to wait for resources or schedule a never reverting call. There must be a way to make it deterministic.

@zugdev
Copy link
Collaborator Author

zugdev commented Nov 12, 2024

So technically your reward is correct,

I understand that, initially I thought it was that recent misconfiguration, but that was related to PR author getting review comments credited. I won't claim for now, I will let him decide what should be done in this case.

@gentlementlegen
Copy link
Member

It seems we get a lot of errors during runs
image

I am not sure if that's because we start to have too many plugins to call.

I am not an expert in workers but, from my experience with distributed systems, it seems super weird that there isn't a way to wait for resources or schedule a never reverting call. There must be a way to make it deterministic.

We also have to check the code itself the error might be totally different but logs are not very verbose within Cloud flare. Let's see if it also occurs on the development bot version because it could also mean some problem in the main branch only.

@zugdev
Copy link
Collaborator Author

zugdev commented Nov 12, 2024

We also have to check the code itself the error might be totally different but logs are not very verbose within Cloud flare. Let's see if it also occurs on the development bot version because it could also mean some problem in the main branch only.

I will look into it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants