-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: code blocks in preview #157
Conversation
Please add Also consider adding a slightly darker background color for the code block. |
Given the background is already very dark adding even an absolute black wouldn't be much visible anyway, so perhaps using a lighter background like here: |
Please consider the inverted style too because when browser is in light mode the following happens: Also:
|
That's better, one last thing check this issue. The code block is unnecessarily overflowing to the right: We want it to look like: It seems it's because of the added padding. If you know a good solution that doesn't involve calc -32px, please use it. |
EDIT: my bad, that did not fix it. https://a642e753.devpool-directory-ui.pages.dev/?issue=2595388408 |
Looks good! Not sure about hard-coded colors tho, @0x4007 RFC |
@dawidsawa, this task has been idle for a while. Please provide an update. |
Resolves #155