Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March Adjustments #21

Closed
0x4007 opened this issue Mar 3, 2024 · 6 comments · Fixed by #23
Closed

March Adjustments #21

0x4007 opened this issue Mar 3, 2024 · 6 comments · Fixed by #23

Comments

@0x4007
Copy link
Member

0x4007 commented Mar 3, 2024

image

  1. No new issue indicators
  2. Personal GitHub image doesn't show (it's built for organizations only)
@Keyrxng
Copy link
Contributor

Keyrxng commented Mar 3, 2024

/start

Copy link

ubiquibot bot commented Mar 3, 2024

DeadlineSun, Mar 3, 11:02 PM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@Keyrxng
Copy link
Contributor

Keyrxng commented Mar 3, 2024

What should the default be for showing a new issue indicator? The isNew was getting wipe after the cache updated every 15 mins, I've hardcoded 3 days but should I move it to env?

@0x4007
Copy link
Member Author

0x4007 commented Mar 5, 2024

What should the default be for showing a new issue indicator? The isNew was getting wipe after the cache updated every 15 mins, I've hardcoded 3 days but should I move it to env?

Just remove the isNew and isModified logic entirely because we need to fully reimplement caching for it to work.

@0x4007 0x4007 closed this as completed in #23 Mar 6, 2024
Copy link

ubiquibot bot commented Mar 6, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Mar 6, 2024

[ 52.8 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification15.2
IssueComment16.8
ReviewComment340.8
Conversation Incentives
CommentFormattingRelevanceReward
![image](https://github.com/ubiquity/work.ubq.fi/assets/4975670/...
5.2
li:
  count: 2
  score: "2"
  words: 16
15.2
> What should the default be for showing a new issue indicator? ...
6.8
code:
  count: 3
  score: "3"
  words: 3
0.786.8
Let's make it simpler. Can we just remove the new issue indicato...
28.2
code:
  count: 2
  score: "4"
  words: 10
0.7328.2
I just checked again on my computer and see that CI failed. Just...
6.40.876.4
Strange, the error did not appear in the latest commit deploymen...
6.20.546.2

[ 204.6 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask1200
IssueComment10
ReviewComment14.6
Conversation Incentives
CommentFormattingRelevanceReward
What should the default be for showing a new issue indicator? Th...
-
code:
  count: 1
  score: "0"
  words: 1
0.7-
I understand the notifications now, the vid shows them working a...
4.60.714.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants