-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fetch personal pp and remove notifications #23
Conversation
Let's make it simpler. Can we just remove the new issue indicator? The CSS and TS code for it. I think in order to properly implement it, the caching needs to be rebuilt entirely, because I poorly implemented the caching the first time around.
I was thinking the same. Do
No the intent is to ensure that its new for the specific user viewing on the client. Not if its a new issue for the network. Its supposed to act like a social media notification in a sense. Or like a GitHub notification. |
I just checked again on my computer and see that CI failed. Just some minor cleanup please https://github.com/ubiquity/work.ubq.fi/actions/runs/8162423256/job/22318480984#step:4:93 |
Strange, the error did not appear in the latest commit deployment for me when I tried in my browser. @FernandVEYRIER any ideas why this would be? I tried incognito as well. |
Not sure, can have a look if that error persist. You can always check the artifacts as well within the Action, like here |
Yes I noticed the screenshot as well. Was curious if there's benefit to doing videos as well, as I saw that as an option in the config. |
Is it possible that Cypress is pulling in the wrong commit? This seems the most likely. However the first deployment doesn't even seem stable. |
Sure I can enable the video, I didn't because it uses a lot of storage and I didn't know about the current limitations. I don't think Cypress would pull the wrong commit, will look into it |
Since we're open source, GitHub sort of gives us unlimited storage etc. |
@FernandVEYRIER I just realized you wrote custom tests for this UI. So this makes sense. You specifically requested that it checks for |
use `eslint-plugin-filename-rules`
Resolves #21
NOTIFICATION_EXPIRY_DAYS = 3
isNew
prop was being wiped after it experienced it's first cache refresh, this way it's based on thecreated_at
which seems like a better approachThe timeframe looks a little squished when it's at defcon 1 don't you think?