-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add labels to preview when necessary #147
Conversation
Mixed feelings on how it looks on mobile but the bottom can't be scrolled to all the way at least in iOS now with the labels offsetting the inner height. |
I think the labels would look better on the bottom on mobile for sure. |
Do you mean you cant scroll to the bottom of the issue list? I've added another PR to add some padding |
Will try it! |
It should be in this pull because this pull introduced the problem. |
trim.AAAF3215-AEE1-4DAA-B0FE-2D15EB737713.MOV |
I just realized that the problem is in production. I think another recent pull introduced the problem. The footer bar is too tall now. I must have overlooked it in another pull. |
Do you have stacked or side by side in mind? I'll attach some quick illustrations for comparison: Stacked: Side by side: Side by side can be good if I can reduce buttons a little, but labels will wrap when too big. IPhone XR demo: |
Side by side but if I had to choose stacked I would make the control buttons on top. |
…into add-labels-to-preview
…into add-labels-to-preview
@0x4007 lmk what you think about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clean on mobile. Not sure on desktop but I'm assuming you also did well there.
A bit concerned about those void statements. I'm not sure if an error is thrown if it will be caught.
Resolves #142
labels-preview.mp4