Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add availability filter for the issues #189

Merged
merged 11 commits into from
Jan 5, 2025

Conversation

koya0
Copy link
Contributor

@koya0 koya0 commented Dec 23, 2024

Resolves #185

QA

qa-filter-availability3.mp4

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Dec 23, 2024

@koya0 koya0 marked this pull request as ready for review December 23, 2024 20:16
@koya0 koya0 requested a review from 0x4007 as a code owner December 23, 2024 20:16
@zugdev
Copy link
Collaborator

zugdev commented Dec 24, 2024

  1. You need to change in style.css the portrait or max-width to account for the new space. To avoid the following:
Screenshot 2024-12-24 at 18 26 55
  1. You should give a little more padding to the new button, notice the difference:
Screenshot 2024-12-24 at 18 28 13
  1. It's preferable that you allocate the same width for both states of the button instead of changeable width, as the later generally provokes responsiveness issues. Also a general better text could be "Unassigned"/"All Issues", i.e: something shorter.

  2. The mobile view is very broken. I think you could split the space between search bar and it in a 3/1 flex split, if that works. Stacking vertically either makes it very convoluted, confusing and also violates the bottom-bar max height (that could be changed, but I dislike the approach)

Screenshot 2024-12-24 at 18 31 14

I'd create a div that wraps search box and the new button has display: flex, then in search box I'd do flex: 3, and in button/label flex: 1. Be careful of how it impacts the desktop view.

@zugdev
Copy link
Collaborator

zugdev commented Dec 26, 2024

LGTM, the only thing I'd change is I'd show all issues when we are displaying all issues and unassigned when displaying unassigned as we do with directory/proposals.

@zugdev zugdev self-requested a review December 26, 2024 23:14
@zugdev
Copy link
Collaborator

zugdev commented Dec 26, 2024

i'd love if u could solve the little window between 1050px and portrait where bottom bar doesnt appear. this happens cause we have two display modes:

  1. portrait OR max_width 1050px

  2. landscape AND width > 800px

bonus problem, but I think just deleting 2 solves :p

@zugdev
Copy link
Collaborator

zugdev commented Dec 27, 2024

thanks, @0x4007 up 2 u

Copy link
Contributor

ubiquity-os bot commented Dec 29, 2024

@koya0, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot marked this pull request as draft December 29, 2024 21:18
@koya0
Copy link
Contributor Author

koya0 commented Dec 29, 2024

@koya0, this task has been idle for a while. Please provide an update.

Waiting @0x4007 for review

@0x4007
Copy link
Member

0x4007 commented Dec 30, 2024

image

The left and right padding should match on both rows

I also wish it was more intuitive to understand if it's currently showing everything or just the assigned issues

But unfortunately I think it would be out of scope to add this: we can show some type of status icon on each task row that indicates if it's available or not. It would be immediately clear what the current filter view state is with this.

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you can fix the padding situation and then merge this in after that's addressed. Thanks.

@koya0
Copy link
Contributor Author

koya0 commented Jan 4, 2025

@0x4007 tks for the feedback

@koya0 koya0 marked this pull request as ready for review January 4, 2025 04:15
@0x4007
Copy link
Member

0x4007 commented Jan 4, 2025

image

Still shifted over https://7e57eb65.devpool-directory-ui.pages.dev

@koya0
Copy link
Contributor Author

koya0 commented Jan 4, 2025

image

Still shifted over https://7e57eb65.devpool-directory-ui.pages.dev

Is shifted only in light mode
image
image
I dont know why, but apparently the div needs more margin-left in light mode, i will fix it.

@koya0
Copy link
Contributor Author

koya0 commented Jan 4, 2025

my localhost is aligned but https://6eb4b888.devpool-directory-ui.pages.dev/ is not

localhost:
image

@koya0
Copy link
Contributor Author

koya0 commented Jan 4, 2025

i guess i cant make changes only for light mode, I reopened the terminal and ran yarn start and an auto change was made in the code to set margin-left equal to the style.css file

@zugdev
Copy link
Collaborator

zugdev commented Jan 5, 2025

ya thats weird, let me take a look

@zugdev
Copy link
Collaborator

zugdev commented Jan 5, 2025

add an and color scheme condition to orientation queries in css

@koya0
Copy link
Contributor Author

koya0 commented Jan 5, 2025

i guess now its fine @zugdev @0x4007

@zugdev
Copy link
Collaborator

zugdev commented Jan 5, 2025

good

@zugdev zugdev merged commit 97b86d7 into ubiquity:development Jan 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Available and In Progress Tasks
3 participants