-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add availability filter for the issues #189
Conversation
LGTM, the only thing I'd change is I'd show all issues when we are displaying all issues and unassigned when displaying unassigned as we do with directory/proposals. |
i'd love if u could solve the little window between 1050px and portrait where bottom bar doesnt appear. this happens cause we have two display modes:
bonus problem, but I think just deleting 2 solves :p |
thanks, @0x4007 up 2 u |
@koya0, this task has been idle for a while. Please provide an update. |
The left and right padding should match on both rows I also wish it was more intuitive to understand if it's currently showing everything or just the assigned issues But unfortunately I think it would be out of scope to add this: we can show some type of status icon on each task row that indicates if it's available or not. It would be immediately clear what the current filter view state is with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust that you can fix the padding situation and then merge this in after that's addressed. Thanks.
@0x4007 tks for the feedback |
Still shifted over https://7e57eb65.devpool-directory-ui.pages.dev |
Is shifted only in light mode |
my localhost is aligned but https://6eb4b888.devpool-directory-ui.pages.dev/ is not |
i guess i cant make changes only for light mode, I reopened the terminal and ran yarn start and an auto change was made in the code to set margin-left equal to the style.css file |
ya thats weird, let me take a look |
add an and color scheme condition to orientation queries in css |
good |
Resolves #185
QA
qa-filter-availability3.mp4