Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: text field is now hidden when not logged in #27

Merged
merged 3 commits into from
Mar 14, 2024
Merged

feat: text field is now hidden when not logged in #27

merged 3 commits into from
Mar 14, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #26

@gentlementlegen gentlementlegen requested a review from rndquu March 14, 2024 03:08
@gentlementlegen gentlementlegen requested a review from 0x4007 as a code owner March 14, 2024 03:08
@gentlementlegen
Copy link
Member Author

gentlementlegen commented Mar 14, 2024 •
edited
Loading

What are the changes of this PR:

  • text is hidden while logged out, visible when logged in
  • the tests were all broken due to the use of OAuth with Supabase, before we use to simply put the token in the localStorage, now the session is really retrieved from Supabase auth
  • while this is a clear improvement, it broke the tests as in I just faked the local storage before. Now, there is a real OAuth workflow going on. Sadly, Oauth cannot be mocked.
  • dummy account was created for this purpose, credentials given to @pavlovcik and @rndquu, should be added to the env UBIQUIBOT_GITHUB_USERNAME and UBIQUIBOT_GITHUB_PASSWORD

0x4007
0x4007 reviewed Mar 14, 2024
View reviewed changes
static/style/style.css Outdated Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Mar 14, 2024

I know that @rndquu changed the Cloudflare deploys. You have the final say on whether to approve and merge this pull!

@rndquu
Copy link
Member

rndquu commented Mar 14, 2024

Works fine

I know that @rndquu changed the Cloudflare deploys.

I haven't yet updated all of the repos with updated build workflow but current PR works fine and can be merged

@gentlementlegen gentlementlegen merged commit 047353e into ubiquity:development Mar 14, 2024
0 of 2 checks passed
@ubiquibot ubiquibot bot mentioned this pull request Mar 14, 2024
Closed
@0x4007
Copy link
Member

0x4007 commented Mar 14, 2024

Seems like it's not on production I tried refreshing several times

@gentlementlegen
Copy link
Member Author

Seems like it's not on production I tried refreshing several times

Still the case so far, got news about this?

@0x4007
Copy link
Member

0x4007 commented Mar 15, 2024

@rndquu might know best

@rndquu
Copy link
Member

rndquu commented Mar 15, 2024

Seems like it's not on production I tried refreshing several times

Still the case so far, got news about this?

Working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 left review comments

@rndquu rndquu rndquu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only Render Text Filter After Logged In
3 participants
@gentlementlegen @0x4007 @rndquu