Skip to content

fix: add state to sorting manager for bottom and top #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Jun 24, 2024

Resolves #69

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jun 24, 2024

@0x4007 0x4007 marked this pull request as ready for review June 24, 2024 12:59
@0x4007 0x4007 requested a review from gentlementlegen June 24, 2024 13:00
@0x4007 0x4007 marked this pull request as draft June 24, 2024 13:00
@0x4007
Copy link
Member Author

0x4007 commented Jun 24, 2024

I always struggle with Cypress

@0x4007
Copy link
Member Author

0x4007 commented Jun 24, 2024

Only doesn't work on my local, the guess is token expiration after one hour and being logged out, but something in our tests is not handling this.

iTerm2 Session Jun 25, 2024 at 00:03:39.rtf.zip

@0x4007 0x4007 marked this pull request as ready for review June 24, 2024 15:05
@gentlementlegen gentlementlegen merged commit 2d22259 into ubiquity:development Jun 24, 2024
2 checks passed
@gentlementlegen
Copy link
Member

After token expiration, I could not reproduce the problem and still had all the tests up and running, as well as Action tests. This should be investigated, if someone else encounters the issue it could give us more clues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Filters to Bottom Bar on Portrait
2 participants