fix(framework-laptop): ensure only in one kmod stream #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be common. However, it isn't quite ready so we are not including in bluefin yet. |
I'm totally fine with common or extra. My goal here is to fix the bug of the kmod being in both right now, and defaulted to what was previously agreed upon. If that's the consensus now I'm happy to switch this PR to common only. Please let me know! |
mulderje
changed the title
|
Given the recent announcements and what @m2Giles mentioned above, changing this to common vs extra. I would like to get a version of this reviewed sooner vs later as |
castrojo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The framework-laptop kmod should only be in extra, but I accidentally put it in both extra and common. No functionality changes expected to the extra package, but will remove framework-laptop from common.
Breaking this out from #177 while that goes through review so it can get cleaned up.