feat: Add tp_smapi from tlp #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just checked out the linrunner repo and it doesn't look like this is available for F41 yet. |
p4p4j0hn
changed the title
p4p4j0hn
changed the title
It is available in the updates-testing repo. |
Older Thinkpads (2011 and older) require this kernel module for battery charge thresholds and recalibration with tlp. You only need this if the Recommendations section from running `tlp-stat -b` includes `Install tp-smapi kernel modules for ThinkPad battery thresholds and recalibration`. fix: Add double quotes to prevent globbing and word-splitting. fix: move tp_smapi to extra image. tp_smapi kmod is for niche users with old thinkpads. It should be part of extras, not common. Signed-off-by: John Schmidt <john@schmidthaus.rocks> fix: use testing repo for F41 Signed-off-by: John Schmidt <john@schmidthaus.rocks>
p4p4j0hn
force-pushed
the
add-tp_smapi
branch
from
53c9976 to
8cec912
Compare
|
@castrojo is this something that could go in here? Or is it too niche? |
|
I think having a diverse set of maintained ones will always be useful for custom images, sorry the review is taking so long! (Outside my skillset) |
KyleGospo
previously approved these changes
Dec 27, 2024
|
Closer! It is building the image just fine, however, it looks like in order to install the akmod during the test, the linrunner repo needs to be added in order to pull in tp_smapi-kmod-common. |
Signed-off-by: John Schmidt <john@schmidthaus.rocks>
auto-merge was automatically disabled
December 29, 2024 20:59
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Thinkpads (2011 and older) require this kernel module for battery charge thresholds and recalibration with tlp. You only need this if the Recommendations section from running
tlp-stat -bincludesInstall tp-smapi kernel modules for ThinkPad battery thresholds and recalibration.