Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore default rpmfusion mirror behavior #89

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Nov 6, 2023

Ah while back, I made a change to akmods/main/nvidia repos to force them to use the same rpmfusion mirror during builds (this gets reset to defaults for resulting images).

This is problematic for F39, since, at the least, it will require a path change due to F39 promoting from "development" to "release".

Should this be removed completely (as I've done in this PR so far) or should we just change the conditional from F39 to F40?

@bsherman bsherman requested a review from a team November 6, 2023 15:14
@bsherman bsherman requested a review from castrojo as a code owner November 6, 2023 15:14
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally haven't noticed a difference between builds before or after this change. Incrementing the check to 40 would work, but I feel like this is actually a better approach

@bsherman
Copy link
Contributor Author

bsherman commented Nov 6, 2023

Given F39 hasn't built in a few builds due to a problem in rpmfusion repos in general... I'm going to force merge this.

@bsherman bsherman merged commit 129b198 into main Nov 6, 2023
@bsherman bsherman deleted the restore-default-rpmfusion-mirrors branch November 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants