feat: ujust command to toggle Tailscale #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
|
Converted to draft. Because only toggling the service might cause confusion, I'm going to make this command toggle the extension and hook it up to gum as well. |
Raindrac
changed the title
|
I've tested the updated script on a local build. It now enables or disables the Tailscale QS extension for Gnome, and when Tailscale is enabled, it notifies the user that they may have to set it up and links them to the documentation. Ready for review! |
dosubot
bot
added
size:M
|
That's great! Looking forward to having this merged. |
|
Alrighty, I'm looking into why the just build check is failing now 🤔 |
|
That should work, I think! It passes the just check locally now. It was just a line ending 😞 |
m2Giles
reviewed
Jul 7, 2024
m2Giles
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a ujust command to toggle the tailscaled service. Because the tailscaled service is active in the background even if the user hasn't set up Tailscale, it increases power usage and battery consumption regardless of whether Tailscale is in use. Users who don't want the service running in the background can now disable it, and this lays the groundwork for making Tailscale opt-in rather than opt-out.
Tested locally on Bluefin. This is my first ujust contribution and the first time I've wrote a bash script, so corrections are welcome.