Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use retry actions to prevent ci jank #1481

Closed
wants to merge 5 commits into from
Closed

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Jul 2, 2024

No description provided.

@m2Giles m2Giles requested a review from castrojo as a code owner July 2, 2024 12:45
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Jul 2, 2024
@m2Giles m2Giles marked this pull request as draft July 2, 2024 12:46
registry: cgr.dev/chainguard
attempt_limit: 3
attempt_delay: 1500
action: EyeCantCU/cosign-action/verify@11f8c114a5e67c7a663c9dfcaf76d85429d254bc # v0.2.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main problem with this action is now Renovate will never upgrade these dependencies.
If we have control over the actions, it would be best if we implement retries from within the action itself

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.... that's not great at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove them from all actions besides the ghcr push. That will be replaced with your action I believe that will have retry in it. Otherwise, the retries will be on inlined run commands.

@m2Giles
Copy link
Member Author

m2Giles commented Jul 15, 2024

This was mostly included in the kernel-cache pr #1502

@m2Giles m2Giles closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants