Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to handle the negativo17-only main image #1748

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Oct 6, 2024

Now that main and hwe images are only providing negativo17, not rpmfusion, the 2 rpmfusion dependent akmods need some extra support, but other areas using rpmfusion can be cleaned up.

Now that main and hwe images are only providing negativo17, not
rpmfusion, the 2 rpmfusion dependent akmods need some extra support, but
other areas using rpmfusion can be cleaned up.
@bsherman bsherman marked this pull request as ready for review October 6, 2024 17:19
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dx Developer Experience Image specific labels Oct 6, 2024
@bsherman bsherman requested review from m2Giles and castrojo and removed request for castrojo October 6, 2024 17:19
@bsherman
Copy link
Contributor Author

bsherman commented Oct 6, 2024

Note that ublue-os/akmods#245 may remove the need to specify the dependencies for the rpmfusion kmod deps, but I won't be sure until will get that merged.

I do think the current PR is good as is regardless.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2024
@castrojo castrojo merged commit a642333 into main Oct 6, 2024
54 checks passed
@castrojo castrojo deleted the negativo17-update branch October 6, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants