chore(ci): replace vanilla kernels not asus/surface #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in #1752 which ignored the fact that asus/surface images in Bluefin are sourced from the HWE images, thus they already have their expected kernels. I do think this end state is a bit nicer though as it is easier to grok that this script only works on specific akmods flavors rather than the nvidia_type which didn't seem to have a clear correlation to replacing the kernel.
dosubot
bot
added
size:S
KyleGospo
approved these changes
Oct 7, 2024
|
This was weirdly stuck in the merge queue, even after all the merge checks were green. So I removed and manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in #1752 which ignored the fact that asus/surface images in Bluefin are sourced from the HWE images, thus they already have their expected kernels.
I do think this end state is a bit nicer though as it is easier to grok that this script only works on specific akmods flavors rather than the nvidia_type which didn't seem to have a clear correlation to replacing the kernel.
I apologize for the noise and confusion on this topic tonight.