Skip to content

Conversation

@hanthor
Copy link

@hanthor hanthor commented Jan 4, 2026

This will crate PRs on new Hombrew versions and it will tag the image with the brew version

Copilot AI review requested due to automatic review settings January 4, 2026 03:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds automated Homebrew version management through Renovate by introducing a BREW_VERSION file and integrating it into the build workflow and Renovate configuration.

  • Introduced BREW_VERSION file containing version 5.0.8
  • Modified build workflow to read and use Brew version as a Docker image tag
  • Updated Renovate configuration to monitor Homebrew/brew releases

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
BREW_VERSION New file storing the Homebrew version (5.0.8) for automated tracking
.github/workflows/build.yml Added step to read BREW_VERSION and use it as an image tag in metadata
.github/renovate.json5 Configured regex manager to track Homebrew/brew releases in BREW_VERSION file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"fileMatch": ["^BREW_VERSION$"],
"matchStrings": [
"https://github\\.com/ublue-os/artwork/releases/download/bluefin-v(?<version>[0-9\\-]+)/bluefin-wallpapers\\.tar\\.zstd"
"^(?<currentValue>.*)"
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern matches any content on the line, which means Renovate will capture the version correctly. However, consider adding validation to ensure the captured value matches a version format (e.g., with anchors or a more specific pattern like ^(?<currentValue>\d+\.\d+\.\d+)$) to avoid capturing invalid content if the file format changes.

Suggested change
"^(?<currentValue>.*)"
"^(?<currentValue>\\d+\\.\\d+\\.\\d+)$"

Copilot uses AI. Check for mistakes.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanthor is it valuable to implement the improved regex or is copilot being over-eager here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do this elsewhere so i figured this is unnecessary

@hanthor
Copy link
Author

hanthor commented Jan 5, 2026

this should be ready to go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hanthor
Copy link
Author

hanthor commented Jan 5, 2026

@p5 can you review this?

@inffy inffy requested a review from p5 January 12, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants