-
Notifications
You must be signed in to change notification settings - Fork 6
feat: renovate for Brew versions #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds automated Homebrew version management through Renovate by introducing a BREW_VERSION file and integrating it into the build workflow and Renovate configuration.
- Introduced BREW_VERSION file containing version 5.0.8
- Modified build workflow to read and use Brew version as a Docker image tag
- Updated Renovate configuration to monitor Homebrew/brew releases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| BREW_VERSION | New file storing the Homebrew version (5.0.8) for automated tracking |
| .github/workflows/build.yml | Added step to read BREW_VERSION and use it as an image tag in metadata |
| .github/renovate.json5 | Configured regex manager to track Homebrew/brew releases in BREW_VERSION file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "fileMatch": ["^BREW_VERSION$"], | ||
| "matchStrings": [ | ||
| "https://github\\.com/ublue-os/artwork/releases/download/bluefin-v(?<version>[0-9\\-]+)/bluefin-wallpapers\\.tar\\.zstd" | ||
| "^(?<currentValue>.*)" |
Copilot
AI
Jan 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex pattern matches any content on the line, which means Renovate will capture the version correctly. However, consider adding validation to ensure the captured value matches a version format (e.g., with anchors or a more specific pattern like ^(?<currentValue>\d+\.\d+\.\d+)$) to avoid capturing invalid content if the file format changes.
| "^(?<currentValue>.*)" | |
| "^(?<currentValue>\\d+\\.\\d+\\.\\d+)$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanthor is it valuable to implement the improved regex or is copilot being over-eager here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't do this elsewhere so i figured this is unnecessary
|
this should be ready to go |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@p5 can you review this? |
This will crate PRs on new Hombrew versions and it will tag the image with the brew version