Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rechunk support #54

Merged
merged 3 commits into from
Aug 7, 2024
Merged

feat: add rechunk support #54

merged 3 commits into from
Aug 7, 2024

Conversation

gerblesh
Copy link
Contributor

@gerblesh gerblesh commented Aug 6, 2024

This PR adds rechunk for reducing image size and fixing existing SELinux issues. Rechunk is very much experimental so I'll continue to test over in: https://github.com/gerblesh/cosmic-rechunk but it's looking mostly stable atm. Build times are slightly longer but still reasonable.
This PR also switches the image away from tuneD and instead uses PPD as PPD has been more receptive to changes for better power efficiency on AMD devices.

castrojo
castrojo previously approved these changes Aug 6, 2024
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooooooooooo.

@gerblesh gerblesh marked this pull request as draft August 6, 2024 01:22
@fiftydinar
Copy link

fiftydinar commented Aug 6, 2024

Tuned will be in F41 though

https://fedoraproject.org/wiki/Changes/TunedAsTheDefaultPowerProfileManagementDaemon

But I agree about preferring PPD over Tuned

@gerblesh
Copy link
Contributor Author

gerblesh commented Aug 6, 2024

Whoops, yeah it does look like an official change for F41, we'll just stick to fedora defaults for now though. PPD has had much better results for battery than tuneD on my AMD framework

@gerblesh gerblesh marked this pull request as ready for review August 6, 2024 21:08
@gerblesh
Copy link
Contributor Author

gerblesh commented Aug 6, 2024

fixed issues with prev-ref and also used skip_compression flag as podman recompresses when pushing to the registry

ryanabx
ryanabx previously approved these changes Aug 7, 2024
Copy link
Member

@ryanabx ryanabx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, my only concern is using a command instead of the build action, but as long as everything builds fine, I'm in full support.

Also +1 to adding nm-tui, I've had issues with the network applet in the past and this will hopefully be a nicer way to work with networking while cosmic sorts out that issue.

@ryanabx ryanabx added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@ryanabx ryanabx added this pull request to the merge queue Aug 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
* feat: rechunk, remove SELinux workarounds

* feat: add nmtui as the GUI is not fully featured
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
…gs (#55)

fix(rechunk): Fix signing by using the appropriate name and change rechunk arguments
Comment on lines +54 to +55
- name: Checkout
uses: actions/checkout@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have we added an old Checkout version here?
We'll start getting warnings about Node 14.x

@castrojo castrojo disabled auto-merge August 7, 2024 17:31
@castrojo castrojo merged commit 7da0b10 into main Aug 7, 2024
11 checks passed
@castrojo castrojo deleted the rechunk branch August 7, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants