Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ip): use pythonping to perform a real ping test instead to determine the internet connection status instead of opening a socket #186

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Oct 19, 2024

This is to make the "check if connected to internet" use the right tooling to reduce the chance of routers limiting packets of the pod.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/system/system_manager/main.py 0.00% 18 Missing ⚠️
ubo_app/services/030-ethernet/ethernet_manager.py 33.33% 6 Missing ⚠️
ubo_app/services/030-wifi/wifi_manager.py 40.00% 6 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 58.16% <33.33%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/services/030-ethernet/setup.py 95.23% <100.00%> (ø)
ubo_app/services/030-ip/setup.py 97.36% <100.00%> (+5.87%) ⬆️
ubo_app/services/030-wifi/reducer.py 89.47% <100.00%> (+0.58%) ⬆️
ubo_app/store/services/ethernet.py 100.00% <100.00%> (ø)
ubo_app/store/services/wifi.py 100.00% <100.00%> (ø)
ubo_app/services/030-ethernet/ethernet_manager.py 68.57% <33.33%> (ø)
ubo_app/services/030-wifi/wifi_manager.py 50.99% <40.00%> (+0.32%) ⬆️
ubo_app/system/system_manager/main.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. please merge

…mine the internet connection status instead of opening a socket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants