Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add recording and replaying indicators, avoid replaying while recording and vice versa, move keypad events to its own reducer as it has grown too big #191

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Oct 30, 2024

ubo-screenshot-000
ubo-screenshot-001

…hile recording and vice versa, move keypad events to its own reducer as it has grown too big
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 56 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/services/000-keypad/reducer.py 32.72% 37 Missing ⚠️
ubo_app/menu_app/menu_header.py 61.53% 10 Missing ⚠️
ubo_app/store/core/reducer.py 50.00% 3 Missing ⚠️
ubo_app/utils/store.py 50.00% 3 Missing ⚠️
ubo_app/side_effects.py 50.00% 2 Missing ⚠️
ubo_app/main.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 58.55% <48.14%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/services/000-keypad/ubo_handle.py 100.00% <100.00%> (ø)
ubo_app/store/core/types.py 100.00% <100.00%> (ø)
ubo_app/store/services/keypad.py 100.00% <100.00%> (ø)
ubo_app/main.py 0.00% <0.00%> (ø)
ubo_app/side_effects.py 48.00% <50.00%> (+0.05%) ⬆️
ubo_app/store/core/reducer.py 75.00% <50.00%> (+17.64%) ⬆️
ubo_app/utils/store.py 46.15% <50.00%> (-3.85%) ⬇️
ubo_app/menu_app/menu_header.py 66.26% <61.53%> (-2.16%) ⬇️
ubo_app/services/000-keypad/reducer.py 32.72% <32.72%> (ø)

@sassanh sassanh merged commit 86de77c into main Oct 30, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant