Open issue when ADMX/L builds fail

[denisonbarbosa]

ADMX/L build failures are sometimes hard to spot and this isn't great. Opening an issue and syncing it to Jira will help us to notice those failures and to start handling them.

Example of issue opened by the action: #756. (It was opened before fixing the job order and without the Jira tag to avoid cluttering Jira with test issues)

UDENG-990

[codecov-commenter]

Codecov Report

Merging #754 (c4e1de3) into main (e0cd683) will decrease coverage by 0.15%.
Report is 42 commits behind head on main.
The diff coverage is 93.25%.

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   86.20%   86.05%   -0.15%     
==========================================
  Files          75       77       +2     
  Lines        8196     8543     +347     
==========================================
+ Hits         7065     7352     +287     
- Misses        814      868      +54     
- Partials      317      323       +6     

Files Changed	Coverage Δ
cmd/adwatchd/commands/main_linux.go	35.00% <0.00%> (ø)
internal/i18n/i18n.go	2.27% <ø> (-95.46%)	⬇️
cmd/adsysd/daemon/scripts.go	75.00% <50.00%> (ø)
cmd/adwatchd/commands/version.go	60.00% <50.00%> (ø)
internal/adsysservice/policy.go	71.55% <50.00%> (-2.49%)	⬇️
cmd/adsysd/client/doc.go	67.96% <60.00%> (ø)
cmd/adsysd/client/policy.go	72.06% <82.22%> (+0.11%)	⬆️
internal/policies/certificate/certificate.go	95.71% <95.55%> (ø)
internal/policies/manager.go	90.49% <97.14%> (+1.51%)	⬆️
cmd/adsysd/client/client.go	80.64% <100.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[GabrielNagy]

Nice work, everything looks good to me!

[didrocks]

I need some investigation before giving my definitive +1:

Would that spam bugs if the job is restarted and fail again? Is it possible to create an unique issue ? We can imagine checking if one is opened first with a particular label (I would say, let’s create a label for it) and then only open if none found?

[denisonbarbosa]

I need some investigation before giving my definitive +1:

Would that spam bugs if the job is restarted and fail again? Is it possible to create an unique issue ? We can imagine checking if one is opened first with a particular label (I would say, let’s create a label for it) and then only open if none found?

@didrocks It won't, no. By default, the action already searches the opened (this can also be changed to look for all or for closed as well, but it doesn't make much sense in our context) issues for one with the exact same name before opening a new one.
There's another option update_existing that can be set to true which makes the action update the existing issue, but the action docs do not specify exactly what kind of update it's talking about. If it's plain overriding (which I think it's the more likely one to be), I'm not sure it's a good idea to use it. But if it appends the content of the new issue into the old one, that could be good.

[didrocks]

Maybe updating the bug description will be interesting? I can see the logs becoming deprecated and so, using a new fresh run URL could be more useful?

Whatever you decide, we can iterate, but I would give this a short.

[denisonbarbosa]

Maybe updating the bug description will be interesting? I can see the logs becoming deprecated and so, using a new fresh run URL could be more useful?

Whatever you decide, we can iterate, but I would give this a short.

Updated the job to update the existing issue and to be explicit that it should only search for open issues (in case the default changes someday)