deps(ci): bump actions/download-artifact from 3 to 4

.github/workflows/patch-vendored-samba.yaml

@@ -39,7 +39,7 @@ jobs:
           done
       - name: Upload
         if: ${{ steps.compute-diff.outputs.changed == 'true' }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: samba
           path: |
@@ -54,7 +54,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Replace with updated Samba source
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           path: .github
       - name: Prepare patch working directory

.github/workflows/policy-builds.yaml

@@ -23,7 +23,7 @@ jobs:
           mkdir /tmp/adsys
           CGO_ENABLED=0 go build ./cmd/admxgen/
       - name: Upload admxgen
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: admxgen
           path: |
@@ -90,7 +90,7 @@ jobs:
       image: ${{ matrix.releases }}
     steps:
       - name: Download admxgen and definition files
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: admxgen
       - name: Install desktop with all default package in container
@@ -111,7 +111,7 @@ jobs:
           artifacts_name=${artifacts_name/:/-}
           echo "artifacts_name=${artifacts_name}" >> $GITHUB_ENV
       - name: Generated definition files
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: policies-${{ env.artifacts_name }}
           path: out/*
@@ -130,7 +130,7 @@ jobs:
           sudo apt-get update
           sudo DEBIAN_FRONTEND=noninteractive apt-get install -y distro-info
       - name: Download all available artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           path: artifacts
       - name: Display structure of downloaded files
@@ -157,7 +157,7 @@ jobs:
           artifacts/admxgen/admxgen admx --auto-detect-releases ${allowflag} artifacts/admxgen/cmd/admxgen/defs/categories.yaml wanted/ .
           ls -R
       - name: Upload adm template files
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: adm-${{ matrix.releases }}
           path: Ubuntu.adm*
@@ -173,7 +173,7 @@ jobs:
           sudo apt-get update
           sudo DEBIAN_FRONTEND=noninteractive apt-get install -y distro-info
       - name: Download all available artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           path: artifacts
       - name: Display structure of downloaded files
@@ -194,7 +194,7 @@ jobs:
           artifacts/admxgen/admxgen doc artifacts/admxgen/cmd/admxgen/defs/categories.yaml wanted/ generated-docs/
           ls -R
       - name: Upload adm template files
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: generated-docs
           path: generated-docs/*
@@ -209,17 +209,17 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Download adm template files for "all"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: adm-ALL
           path: policies/Ubuntu/all
       - name: Download adm template files for lts only
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: adm-LTS
           path: policies/Ubuntu/lts-only
       - name: Download generated documentation
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: generated-docs
           path: docs/reference/policies/

.github/workflows/qa.yaml

@@ -119,7 +119,7 @@ jobs:
         # detection enabled and the code is mostly platform independent, this
         # should be a safe action to take.
       - name: Attach installer artifact to workflow run
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: adwatchd_setup
           path: installer/Output/adwatchd_setup.exe