Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(i18n): Move to external go-i18n and gotext #886

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

didrocks
Copy link
Member

@didrocks didrocks commented Jan 2, 2024

We did the work to avoid our internal/ package last cycle. Move now to
it.
We still need to validate each lines that we log or not.

This removes the need for snapcore go-gettext.

UDENG-1990

@didrocks didrocks force-pushed the move-to-external-go-i18n branch 2 times, most recently from 2ea8dbe to 2537d24 Compare January 2, 2024 15:45
We did the work to avoid our internal/ package last cycle. Move now to
it.
We still need to validate each lines that we log or not.
@codecov-commenter
Copy link

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (3c4da75) 86.00% compared to head (06b6526) 86.43%.

Files Patch % Lines
internal/watcher/watcher.go 75.00% 7 Missing ⚠️
internal/policies/apparmor/apparmor.go 81.25% 6 Missing ⚠️
internal/ad/admxgen/admxgen.go 73.68% 5 Missing ⚠️
internal/ad/admxgen/dconf/dconf.go 54.54% 5 Missing ⚠️
internal/watchdservice/watchdservice.go 83.87% 5 Missing ⚠️
internal/ad/ad.go 82.60% 4 Missing ⚠️
internal/adsysservice/doc.go 33.33% 4 Missing ⚠️
internal/authorizer/servercreds.go 40.00% 3 Missing ⚠️
internal/cmdhandler/suggest.go 40.00% 3 Missing ⚠️
internal/config/watchd/watchd.go 66.66% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   86.00%   86.43%   +0.42%     
==========================================
  Files          76       75       -1     
  Lines        8718     8675      -43     
==========================================
  Hits         7498     7498              
+ Misses        883      840      -43     
  Partials      337      337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didrocks didrocks marked this pull request as ready for review January 2, 2024 16:46
@didrocks didrocks requested a review from a team as a code owner January 2, 2024 16:46
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@didrocks didrocks merged commit 7ea2aa1 into main Jan 3, 2024
16 checks passed
@didrocks didrocks deleted the move-to-external-go-i18n branch January 3, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants