fix: remove NDES requirement from certificate auto-enrollment #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To pick up the NDES fixes from upstream, specifically https://gitlab.com/samba-team/samba/-/merge_requests/3496 This allows certificate auto-enrollment to function without NDES being present on the Windows Server. Fixes #883 / UDENG-1984
This role is no longer required after the latest Samba update.
GabrielNagy
changed the title
|
Tested this on Ubuntu Mantic and confirmed auto-enrollment now works with and without the NDES role installed. |
jibel
approved these changes
Jan 25, 2024
|
Thanks @GabrielNagy, great work! |
GabrielNagy
added a commit
that referenced
this pull request
Jan 26, 2024
This is an out of band release on account of the certificate auto-enrollment fix in #892.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the vendored samba bits to latest in order to pick up the NDES fixes from upstream, specifically https://gitlab.com/samba-team/samba/-/merge_requests/3496.
This allows certificate auto-enrollment to function without NDES being present on the Windows Server.
Fixes #883 / UDENG-1984