Snap ratings #12
Merged
Snap ratings #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthew-hagemann
commented
Oct 10, 2023
•
matthew-hagemann
commented
- Snap packaging for Ratings service
- Updated charm to make use of the snap instead of a raw install + systemd
- Added integration + functional tests
- Updated CI pipelines
Closed
matthew-hagemann
force-pushed
the
snap-ratings
branch
from
0d177b2
to
42a810b
Compare
matthew-hagemann
force-pushed
the
snap-ratings
branch
2 times, most recently
from
96b1741
to
6b022cf
Compare
matthew-hagemann
force-pushed
the
snap-ratings
branch
from
6b022cf
to
129b510
Compare
|
@jnsgruk I have made the changes you recommenced. If you are able, I'd really appreciate a review of the changes regarding the snap and using it in the charm 🙂 |
jnsgruk
suggested changes
Oct 11, 2023
fix(snap): remove placeholder connection uri's fix(snap): randomized default jwt fix(snap): use install over cp + chmod fix(app): remove debug logs fix(snap): prevent snap from starting on install docs(charm): update config to match README.md fix(charm): remove option restart on config change
|
Thank you @jnsgruk! I have made those changes 🙂 WRT not starting the snap on install/until the configuration values have been set, would we want to also update the start hook in the charm to not invoke start on the snap, but maybe just update the unit message to "waiting on database relation"? Then only actually invoke start when the relation is created? |
This was referenced Oct 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.