Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(go): Bump dependency on go-pam to ignore compilation warning #182

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Jan 19, 2024

Bump go-pam requirement so that we do ignore unused-variables warning on cgo generated code.

It basically includes msteinert/pam#22

Closes: #179

UDENG-2104

Bump go-pam requirement so that we do ignore unused-variables warning on
cgo generated code.
@3v1n0 3v1n0 requested a review from a team as a code owner January 19, 2024 15:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4141f37) 83.61% compared to head (64ee73e) 83.60%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   83.61%   83.60%   -0.02%     
==========================================
  Files          58       58              
  Lines        4724     4721       -3     
==========================================
- Hits         3950     3947       -3     
  Misses        599      599              
  Partials      175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! We can now see that in build or in the tests, this don’t fail anymore.

@didrocks didrocks merged commit 913b3b3 into ubuntu:main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning during build should fail or not be displayed.
3 participants