Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resolve accessibility issues by disabling problematic table buttons #75

Open
wants to merge 1 commit into
base: fix/resolve_508_issues_in_cohort_characterization
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions js/components/analysisExecution/analysis-execution-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ <h2 data-bind="css: classes('title'), text: ko.i18n('components.analysisExecutio
dataTable: {
data: filteredExecutionGroups,
options: {
searching: false, // No need for search...less is more
paging: false, // Disable pagination
buttons: [], // Ensure no buttons are displayed
columns: sourcesColumn,
order: [[ 0, 'asc' ]],
pageLength: tableOptions.pageLength,
// pageLength: tableOptions.pageLength,
language: ko.i18n('datatable.language')
}
}
Expand Down Expand Up @@ -109,9 +112,11 @@ <h2 data-bind="css: classes('title'), text: ko.i18n('components.analysisExecutio
dataTable: {
data: submissions,
options: {
paging: false, // Disable pagination
buttons: [], // Ensure no buttons are displayed
columns: execColumns,
order: [[ 0, 'desc' ]],
pageLength: $component.tableOptions.pageLength,
// pageLength: $component.tableOptions.pageLength,
language: ko.i18n('datatable.language')
}
}
Expand Down
8 changes: 6 additions & 2 deletions js/components/checks/warnings.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@
<div data-bind="css: classes()">
<faceted-datatable params="{
columns: warningsColumns,
options: warningsOptions,
options: {
paging: false, // Disable pagination
searching: false, // Disable the search bar...less is more
},
buttons: [], // Ensure no buttons are displayed
reference: warnings,
pageLength: tableOptions.pageLength,
// pageLength: tableOptions.pageLength,
lengthMenu: tableOptions.lengthMenu,
order: [],
language: ko.i18n('datatable.language')
Expand Down
12 changes: 4 additions & 8 deletions js/components/conceptset/conceptset-editor.html
Original file line number Diff line number Diff line change
@@ -1,23 +1,19 @@
<table class="conceptSetTable stripe compact hover" cellspacing="0" width="100%" data-bind="dataTable:{
data: conceptSetItems(),
buttons: [], // Ensure no buttons are displayed
options: {
dom: 'Clfiprt',
colVis: {
buttonText: ko.i18n('datatable.language.buttons.changeColumns', 'Change Columns'),
align: 'right',
overlayFade: 0,
showAll: ko.i18n('datatable.language.buttons.showAllColumns', 'Show All Columns'),
restore: ko.i18n('datatable.language.buttons.resetColumns', 'Reset Columns')
},
rowCallback: $component.commonUtils.contextSensitiveLinkColor,
lengthMenu: $component.tableOptions.lengthMenu,
pageLength: $component.tableOptions.pageLength,
// pageLength: $component.tableOptions.pageLength,
orderClasses: false,
deferRender: true,
autoWidth: false,
order: [[3, 'desc']],
language: ko.i18n('datatable.language'),
columns: columns,
paging: false, // Disable pagination
searching: true, // Keep the search bar
}
}">
<thead>
Expand Down
2 changes: 2 additions & 0 deletions js/components/conceptset/conceptset-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ define([
this.options = {
deferRender: true,
orderClasses: false,
paging: false, // Disable pagination
searching: true, // Keep the search bar
autoWidth: false,
order: [ 1, 'asc' ],
...commonUtils.getTableOptions('S'),
Expand Down
9 changes: 6 additions & 3 deletions js/components/entityBrowsers/characterization-browser.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,17 @@
autoWidth: false,
reference:data,
columns: columns,
options: options,
buttons: buttons,
options: {
paging: false, // Disable pagination
searching: true, // Keep the search bar
},
buttons: [], // Ensure no buttons are displayed
dom: tableDom,
rowClick: !multiChoice ? rowClick : null,
scrollY: scrollY,
selectedData: filteredData,
dtApi: dtApi,
pageLength: pageLength,
// pageLength: pageLength,
lengthMenu: lengthMenu,
language: ko.i18n('datatable.language')
">
Expand Down
6 changes: 4 additions & 2 deletions js/components/linked-entity-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ <h2 data-bind="css: classes('title'), text: $component.title"></h2>
dataTable:{
data: $component.data,
options: {
paging: false, // Disable pagination
searching: false, // Disable the search bar
columns: $component.columns,
pageLength: $component.tableOptions.pageLength,
lengthMenu: $component.tableOptions.lengthMenu,
// pageLength: $component.tableOptions.pageLength,
// lengthMenu: $component.tableOptions.lengthMenu,
language: $component.language
}
}
Expand Down
8 changes: 6 additions & 2 deletions js/components/versions/versions.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
<faceted-datatable params="{
order: [2, 'desc'],
columns: columns,
options: options,
options: {
paging: false, // Disable pagination
searching: true, // Keep the search bar
},
buttons: [], // Ensure no buttons are displayed
reference: data,
pageLength: tableOptions.pageLength,
// pageLength: tableOptions.pageLength,
lengthMenu: tableOptions.lengthMenu,
language: ko.i18n('datatable.language')
}"></faceted-datatable>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
</button>
<button type="button" class="btn btn-primary" data-bind="click: closeCharacterization, css: {disabled: isProcessing() }, title: ko.i18n('common.close', 'Close')"><i class="fa fa-times"></i></button>
<!-- ko ifnot: isNewEntity() -->
<!-- Hide this not-so-useful part and make the page more 508 compliant:
<button type="button" class="btn btn-primary" data-bind="click: () => isTagsModalShown(!isTagsModalShown()), visible: isEditPermitted() && !previewVersion(), css: { disabled: isProcessing() }, title: ko.i18n('common.tags', 'Tags')"><i class="fa fa-tags"></i></button>
-->
<button type="button" class="btn btn-primary" data-bind="visible: !previewVersion(), click: copyCc, css: {disabled: !canCopy() || isProcessing() }, title: , title: ko.i18n('common.createACopy', 'Create a copy')"><i class="fa fa-copy"></i></button>

<!-- ko if: enablePermissionManagement -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,18 @@
autoWidth: false,
reference: data,
columns: columns,
options:options,
buttons: buttons,
options: {
paging: false, // Disable pagination
searching: true, // Keep the search bar
},
buttons: [], // Ensure no buttons are displayed
dom: tableDom,
rowClick: !multiChoice ? rowClick : null,
scrollY: scrollY,
scrollCollapse: scrollCollapse,
selectedData: filteredData,
dtApi: dtApi,
pageLength: tableOptions.pageLength,
// pageLength: tableOptions.pageLength,
lengthMenu: tableOptions.lengthMenu,
language: ko.i18n('datatable.language')
">
Expand Down
8 changes: 6 additions & 2 deletions js/pages/characterizations/components/tabbed-grid.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,13 @@
<faceted-datatable params="{
order: $component.order,
columns: $component.gridColumns,
options: $component.gridOptions,
options: {
paging: false, // Disable pagination
searching: true, // Keep the search bar
},
buttons: [], // Ensure no buttons are displayed
reference: $component.data,
pageLength: $component.tableOptions.pageLength,
// pageLength: $component.tableOptions.pageLength,
lengthMenu: $component.tableOptions.lengthMenu,
language: $component.datatableLanguage
}"></faceted-datatable>
Expand Down
Loading