Update deprecated js_include in nginx configs #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawadqur
changed the title
|
Please find the ci env pod logs here |
mfshao
reviewed
Feb 6, 2025
kube/services/revproxy/nginx.conf
Outdated
| @@ -247,7 +247,7 @@ server { | |||
| more_set_headers "Access-Control-Expose-Headers: Content-Length,Content-Range"; | |||
|
|
|||
| # update service release cookie | |||
| add_header Set-Cookie "service_releases=${service_releases};Path=/;Max-Age=600;HttpOnly;Secure;SameSite=Lax"; | |||
| # add_header Set-Cookie "service_releases=${service_releases};Path=/;Max-Age=600;HttpOnly;Secure;SameSite=Lax"; | |||
There was a problem hiding this comment.
is this intentional? I thought this is to add some madatory security related cookies
There was a problem hiding this comment.
This is/ was used for some canary deployments, which was never fully implemented. We could keep it in, but I don't think we need it.
mfshao
approved these changes
Feb 6, 2025
Please find the detailed integration test report here Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes