Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Sheepdog populating version info incorrectly #431

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented Feb 20, 2025

Link to JIRA ticket if there is one: MIDRC-938

Bug Fixes

  • Fixed: version_data.py was being updated at an incorrect location during docker image build

Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@nss10 nss10 changed the title Test/version_check [Fix] Sheepdog populating version info incorrectly Feb 20, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13446093270

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.905%

Totals Coverage Status
Change from base Build 13140530077: 0.0%
Covered Lines: 2353
Relevant Lines: 3801

💛 - Coveralls

Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#ffa500}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{13}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{14}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{9}}$$
$$\textcolor{#ffa500}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{21}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@nss10 nss10 merged commit 7a675d5 into master Feb 21, 2025
11 checks passed
@nss10 nss10 deleted the test/version_check branch February 21, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants