Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/port demo #4

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9f9c96a
spike(PortDemo): Initial commit
jarvisraymond-uchicago Dec 19, 2024
6627534
spike(PortDemo): Added icons
jarvisraymond-uchicago Dec 19, 2024
700ec78
spike(PortDemo): Began porting team projects UI
jarvisraymond-uchicago Dec 20, 2024
3db34f7
spike(PortDemo): fixed spacing
jarvisraymond-uchicago Dec 20, 2024
f6d14ee
spike(PortDemo): Added VADC style sheet, removed all other style shee…
jarvisraymond-uchicago Jan 3, 2025
040dfd9
spike(PortDemo): Fixed attrition table animation
jarvisraymond-uchicago Jan 3, 2025
d74ac78
spike(PortDemo): updated tailwind styles to look more like current apps
jarvisraymond-uchicago Jan 3, 2025
e40f83d
spike(PortDemo): cleaned up AttritionTableWrapper types and styles
jarvisraymond-uchicago Jan 3, 2025
cce3553
spike(PortDemo): cleaned up Tour Button types
jarvisraymond-uchicago Jan 3, 2025
2fdd268
spike(PortDemo): cleaned up AddCohortButton, SearchBar and SelectCoho…
jarvisraymond-uchicago Jan 3, 2025
5a9c743
spike(PortDemo): Added variable Endpoints
jarvisraymond-uchicago Jan 22, 2025
f0f3d3b
spike(PortDemo): resolved LINT issues
jarvisraymond-uchicago Jan 22, 2025
dfeca5d
spike(PortDemo): removed styles breaking compilation
jarvisraymond-uchicago Jan 22, 2025
e99efae
spike(PortDemo): removed missing prop breaking compilation
jarvisraymond-uchicago Jan 22, 2025
125b869
spike(PortDemo): removed missing type breaking compilation
jarvisraymond-uchicago Jan 22, 2025
d08b124
spike(PortDemo): added type breaking compilation
jarvisraymond-uchicago Jan 22, 2025
85e278b
spike(PortDemo): added type breaking compilation
jarvisraymond-uchicago Jan 22, 2025
ba63c5f
spike(PortDemo): fixed remaining missing types breaking compilation
jarvisraymond-uchicago Jan 22, 2025
cd13e8a
spike(PortDemo): moved app from pages to lib
jarvisraymond-uchicago Jan 22, 2025
6c4ae7d
spike(PortDemo): Added storybook, renamed old storybook files to OLDs…
jarvisraymond-uchicago Jan 22, 2025
83aefdd
spike(PortDemo): Removed boiler plate stories, updated existing story…
jarvisraymond-uchicago Jan 22, 2025
215ee87
spike(PortDemo): removed first empty object instance to try to fix co…
jarvisraymond-uchicago Jan 22, 2025
b166c2f
spike(PortDemo): removed unneeded state fro CohortDefinations selecte…
jarvisraymond-uchicago Jan 23, 2025
bc15bf9
spike(PortDemo): Added Allow-listing false positives comment to MSW
jarvisraymond-uchicago Jan 23, 2025
19597a4
spike(PortDemo): Added interaction test
jarvisraymond-uchicago Jan 24, 2025
5e72761
spike(PortDemo): Added easier to explain interaction test
jarvisraymond-uchicago Jan 24, 2025
a700740
spike(PortDemo): Removed unneeded imports
jarvisraymond-uchicago Jan 24, 2025
f9ef2da
spike(PortDemo): Removed unneeded import
jarvisraymond-uchicago Jan 24, 2025
3a3ae3c
spike(PortDemo): Removed unneeded comment
jarvisraymond-uchicago Jan 24, 2025
bc030be
spike(PortDemo): Added documentation comment
jarvisraymond-uchicago Jan 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,7 @@ module.exports = {
es2021: true,
node: true,
},
extends: [
'eslint:recommended',
'plugin:jsx-a11y/recommended',
'plugin:react/recommended',
'plugin:react-hooks/recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@next/next/recommended',
'prettier',
],
extends: ['eslint:recommended', 'plugin:jsx-a11y/recommended', 'plugin:react/recommended', 'plugin:react-hooks/recommended', 'plugin:@typescript-eslint/recommended', 'plugin:@next/next/recommended', 'prettier', 'plugin:storybook/recommended'],
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaFeatures: {
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
name: CI
on: push
jobs:
interaction-and-accessibility:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: 20.17.0
- name: Install dependencies
run: npm install
- name: Install Playwright
run: npx playwright install --with-deps
- name: Build Storybook
run: npm run build-storybook --quiet
- name: Serve Storybook and run tests
run: |
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server storybook-static --port 6006 --silent" \
"npx wait-on tcp:6006 && yarn test-storybook"
build:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,5 @@ yarn-error.log*
# typescript
*.tsbuildinfo
next-env.d.ts

*storybook.log
38 changes: 38 additions & 0 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import type { StorybookConfig } from '@storybook/nextjs';

const config: StorybookConfig = {
stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'],
addons: [
'@storybook/addon-onboarding',
'@storybook/addon-essentials',
'@chromatic-com/storybook',
'@storybook/addon-interactions',
'@storybook/addon-a11y',
],
framework: {
name: '@storybook/nextjs',
options: {},
},
staticDirs: ['../public'],
webpackFinal: async (config) => {
const imageRule = config.module?.rules?.find((rule) => {
const test = (rule as { test: RegExp }).test;

if (!test) {
return false;
}

return test.test('.svg');
}) as { [key: string]: any };

imageRule.exclude = /\.svg$/;

config.module?.rules?.push({
test: /\.svg$/,
use: ['@svgr/webpack'],
});

return config;
},
};
export default config;
34 changes: 34 additions & 0 deletions .storybook/preview.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import React from 'react';
import type { Preview } from '@storybook/react';
import { MantineProvider } from '@mantine/core';
import '../src/styles/globals.css';
import { initialize, mswLoader } from 'msw-storybook-addon';

/*
* Initializes MSW
* See https://github.com/mswjs/msw-storybook-addon#configuring-msw
* to learn how to customize it
*/
initialize();

const preview: Preview = {
parameters: {
controls: {
matchers: {
color: /(background|color)$/i,
date: /Date$/i,
},
},
},
tags: ['autodocs'],
decorators: [
(Story) => (
<MantineProvider>
<Story />
</MantineProvider>
),
],
loaders: [mswLoader], // 👈 Adds the MSW loader to all stories
};

export default preview;
22 changes: 22 additions & 0 deletions .storybook/test-runner.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import type { TestRunnerConfig } from '@storybook/test-runner';
import { injectAxe, checkA11y } from 'axe-playwright';

/*
* See https://storybook.js.org/docs/writing-tests/test-runner#test-hook-api
* to learn more about the test-runner hooks API.
*/
const config: TestRunnerConfig = {
async preVisit(page) {
await injectAxe(page);
},
async postVisit(page) {
await checkA11y(page, '#storybook-root', {
detailedReport: true,
detailedReportOptions: {
html: true,
},
});
},
};

export default config;
Loading