Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache rarely-changing allowance-related DB objects #506

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

matthew-li
Copy link
Collaborator

@matthew-li matthew-li commented Feb 6, 2023

Description

**** Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ****

  • Cached an instance of ComputingAllowanceInterface under the key "computing_allowance_interface" during the new project request form to avoid many redundant database lookups of the same objects.
  • Updated new project request forms to take an already-instantiated instance of the class instead of creating a new one.

Type of change

**** Please delete options that are not relevant. ****

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ****

TODO.

PR Self Evaluation

Strikethrough things that don’t make sense for your PR.

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if needed)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

@matthew-li matthew-li marked this pull request as draft October 14, 2024 20:47
@matthew-li matthew-li changed the title [WIP/Do Not Merge] Introduce django-redis as cache backend; cache essentially static object Cache rarely-changing allowance-related DB objects Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant