WIP Issue 399 part 2: MOU Generation #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rojects with local disk
matthew-li
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks a lot for getting this working!
I left some comments mostly regarding code quality and documentation. (I haven't tested this yet.)
I'm also thinking that we should move the generation workflow out to a separate application so as not to store hard-coded text/images here (any changes to them would require a redeploy of this app, which may be annoying). We're doing something similar with billing ID validation on the LRC side--I created a separate Python app that can be used from this one so as not to concern this web service with those details.
coldfront/core/project/forms_/new_project_forms/request_forms.py
Outdated
Show resolved
Hide resolved
…ckend Add local file system backend for storing MOU files; add documentation for MOU storage + generation
matthew-li
reviewed
Jan 22, 2024
matthew-li
reviewed
Jan 29, 2024
coldfront/core/project/templates/project/project_allocation_addition/request_card.html
Outdated
Show resolved
Hide resolved
matthew-li
reviewed
Jan 29, 2024
matthew-li
reviewed
Jan 29, 2024
...front/core/allocation/templates/secure_dir/secure_dir_request/secure_dir_request_detail.html
Outdated
Show resolved
Hide resolved
matthew-li
reviewed
Feb 6, 2024
...front/core/allocation/templates/secure_dir/secure_dir_request/secure_dir_request_detail.html
Outdated
Show resolved
Hide resolved
matthew-li
reviewed
Feb 6, 2024
coldfront/core/allocation/templates/secure_dir/secure_dir_request/secure_dir_request_card.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.