Issue 585: Ensure that users cannot be added to "New" / "Inactive" / "Archived" projects #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**** Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ****
The views where users could be added to projects were updated to be blocked for all projects that do not have the
Active
status.Checks for the Project Detail Page:
PIs/Managers for a certain project can add other users to the project via the
Add Users
button underManage Project
. This button is disabled if the given project's status is notActive
. If the user attempts to bypass this check by addingadd-users-search/
to their URL (thus accessing theProjectAddUsersSearchView
, they are redirected back to the Project Detail page and an error message appears.ProjectAddUsersSearchResultsView
is also blocked off for all projects without anActive
status.Checks for Join Page:
Users may send a join request for a project by navigating to
/project/join/
, where all projects withActive
statuses are placed in a list. TheProjectJoinView
was also blocked off for all non-active projects.Fixes #585
Type of change
**** Please delete options that are not relevant. ****
How Has This Been Tested?
**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ****
Inactive
,Archived
, orNew
projects.coldfront.core.project.tests.test_views.test_add_user_views
andcoldfront.core.project.tests.test_views.test_join_views
.PR Self Evaluation
Strikethrough things that don’t make sense for your PR.