Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #1609

Merged
merged 22 commits into from
Dec 5, 2024
Merged

Dark Mode #1609

merged 22 commits into from
Dec 5, 2024

Conversation

SimonRothUCF
Copy link
Contributor

Adds dark mode styles to the Materia website as well as a toggle on the settings page.

@clpetersonucf clpetersonucf changed the base branch from master to dev/10.3.0 September 19, 2024 19:24
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visual changes are terrific, and we discussed the issue with duplicate styles in our one-on-one. Here are some minor issues I identified while looking through the site:

Header:

  • Materia top-left logo is a PNG. Should be SVG for both, with light and dark strokes (I can provide the original illustrator source file/SVG if needed)
  • Support hover links in header are not styled for dark mode (requires your local user to have the support_user role, instructions for doing that here.

My Widgets:

  • Excessive box-shadow around My Widgets container in light mode
  • instance search input too dark, text is black
  • Student Activity -> Individual Scores search input is too dark, text is black
  • Share with your Students -> Play URL and Embed Code inputs too light, should be consistent with dark mode inputs
  • Settings Dialog -> Attempts slider not styled for dark mode
  • Collaborate -> Search input not styled for dark mode
  • Copy -> Search input not styled for dark mode

Score Screen:

  • Score Screen -> Content area BG Too light. Default table cells BG too dark. Colored correct/incorrect cells too light. Score circle BG text should be light.

Admin panels:

  • User and Instance Admin content areas are not styled for dark mode

Widget Pre-embeds:

  • Updated pre-embed views (No attempts, not yet available, embedded only) need to be fixed when using dark mode. This one isn't 100% on you, I modified these views in 10.3.0, they'll just need dark mode variants.

Additionally, I committed the style cleanup changes I already made and opened a PR targeting this branch, which is available here: SimonRothUCF#1

Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a few things here and there we missed, but I'm pretty happy with it overall. Thank you for your hard work on this.

@clpetersonucf clpetersonucf merged commit 5769e93 into ucfopen:dev/10.3.0 Dec 5, 2024
2 checks passed
@clpetersonucf clpetersonucf mentioned this pull request Dec 6, 2024
@mrash2
Copy link

mrash2 commented Jan 9, 2025

@clpetersonucf Any thoughts as to what could be going on if I'm not seeing the Dark Mode toggle within the profile settings for users in 10.3.0? It's not a big issue, but since I know you've been working with one of UT Knoxville's contractors to get us moved from 8.x over to 10.3, I thought I'd check with you. You may have some context specific to our situation where we don't really need to submit a proper issue.

Again - it's not a major problem; I just want to make sure we're properly running on the latest version, and I know you and Mike have had some discussions about our approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants