-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerized Faculty Tools #22
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status checks are failing on this PR. It looks like it's a MDL configuration issue with Travis. That particular check should be easy to work around, but this PR also fails to address how "dockerizing" the application will affect CI.
Though, instead of fixing the Travis setup, we should probably be using GitHub Actions anyways (see newly-created #23)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked well for me, though I did run into a snag getting it working because API_URL is being used as a BASE_URL in settings.py, and running this with /api/v1 added causes an error to be thrown by the consumer/Canvas that's not super clear. I'd recommend a possible variable name change or clarification in .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: Part One (To be continued)
Need some doc updates to help avoid confusion from devs unfamiliar with the project trying to stand up an instance.
Also, I couldn't get the database to load. Error is in one of the comments below.
Proposed Changes
Fixes #21