-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Cache #1114
Merged
Merged
Image Cache #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a great place to look to understand how the two content harvester caches work, though.
amywieliczka
force-pushed
the
1109-img-cache
branch
from
September 24, 2024 19:49
69a5a62
to
5fa3b9f
Compare
amywieliczka
force-pushed
the
1109-img-cache
branch
from
September 24, 2024 21:52
89e9669
to
290d85e
Compare
amywieliczka
force-pushed
the
1109-img-cache
branch
from
September 24, 2024 22:25
68a1f9d
to
7a0f50a
Compare
amywieliczka
force-pushed
the
1109-img-cache
branch
from
September 25, 2024 00:01
a63bd36
to
c0c66c4
Compare
amywieliczka
force-pushed
the
1109-img-cache
branch
from
September 25, 2024 00:24
945c9da
to
1745d17
Compare
bibliotechy
reviewed
Sep 26, 2024
bibliotechy
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s3 implementation looks good. One small non-blocker comment
amywieliczka
force-pushed
the
1109-img-cache
branch
from
September 26, 2024 01:26
89ca7e0
to
bafb18f
Compare
barbarahui
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1109
Stores thumbnail and media components on s3 at a configured
CONTENT_COMPONENT_CACHE
set tos3://<bucket>/<prefix>/
at the key:<collection_id>/<request.url>/<component_type: media|thumbnail>/<ETag>/<Last-Modified>
Where request.url, etag, and last-modified have all been run through
urllib.parse.quote_plus
to encode them.Thumbnail and Media Components are defined as: