Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip date string after splitting on ; #1131

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

barbarahui
Copy link
Collaborator

@barbarahui barbarahui commented Oct 11, 2024

Date values like this: ["1494; 1495"] look like this after enrichment: ["1494", " 1495"]

Note the space before "1495". Not sure how critical it is to remove this, but the validation report was flagging it as a problem, and maybe it affects the decade faceting?

Copy link
Collaborator

@amywieliczka amywieliczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks for looking at the validation reports.

@barbarahui barbarahui merged commit e2bc787 into main Oct 14, 2024
3 checks passed
@barbarahui barbarahui deleted the date-semicolon-split-bug branch October 14, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants