Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucb_tind_mapper #1142

Merged
merged 10 commits into from
Oct 30, 2024
Merged

ucb_tind_mapper #1142

merged 10 commits into from
Oct 30, 2024

Conversation

barbarahui
Copy link
Collaborator

@barbarahui barbarahui commented Oct 22, 2024

This is based on Lucas's marc mapper work here: #674 . However, the code had diverged so much since that PR that it made sense to start a fresh PR.

Differences from Lucas's PR:

  • Created a single ucb_marc_tind_mapper rather than a parent marc_mapper plus child ucb_marc_tind_mapper
  • "Listify" extent field values
  • Add field 710 to creator
  • Pair 880 subfield values with the correct "primary" subfield value. This update necessitated the most code changes.

@barbarahui barbarahui changed the title Tind mapper runs ucb_tind_mapper Oct 24, 2024
@barbarahui barbarahui linked an issue Oct 28, 2024 that may be closed by this pull request
@barbarahui barbarahui marked this pull request as ready for review October 30, 2024 18:27
amywieliczka
amywieliczka previously approved these changes Oct 30, 2024
@barbarahui barbarahui merged commit c7555dd into main Oct 30, 2024
2 checks passed
@barbarahui barbarahui deleted the marc-2 branch October 30, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UCBTIND_MARCMapper(PyMarcMapper)
2 participants