Remove couchdb env vars #1149
Merged
Remove couchdb env vars #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbarahui
commented
Nov 4, 2024
| @@ -266,7 +265,7 @@ def validate_endpoint_task(url, mapped_versions, params=None, **context): | |||
| print(f"please validate manually: {list(errored_collections.keys())}") | |||
| print("*" * 60) | |||
|
|
|||
| if not len(errored_collections) == len(validations): | |||
| if len(errored_collections) == len(validations): | |||
There was a problem hiding this comment.
@amywieliczka It seems like this was an error in logic, but I might not be understanding what exactly this is trying to achieve? Right now, if we are validating one collection, and the validation succeeds, then this causes a ValueError to be raised, and the task fails.
There was a problem hiding this comment.
Huh, yeah, that looks like an error.
barbarahui
force-pushed
the
remove-couchdb-env-vars
branch
from
1aab144 to
cf11a4d
Compare
amywieliczka
approved these changes
Nov 4, 2024
| @@ -266,7 +265,7 @@ def validate_endpoint_task(url, mapped_versions, params=None, **context): | |||
| print(f"please validate manually: {list(errored_collections.keys())}") | |||
| print("*" * 60) | |||
|
|
|||
| if not len(errored_collections) == len(validations): | |||
| if len(errored_collections) == len(validations): | |||
There was a problem hiding this comment.
Huh, yeah, that looks like an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes use of
UCLDC_COUCH_URLandUCLDC_COUCH_TIMEOUTenv vars from the codebase, as CouchDB is no longer running.When running the
harvest_collectiondag, the validation report generation was getting skipped. We decided to reinstate it.When running the validator, the reports will be created without validating
isShownAtandisShownBy, since those validations rely on CouchDB data.I did not actually do the work of stripping out all of the logic relating to couchdb. I figure it makes sense to do that when we overhaul the validator to compare against OpenSearch data.
There is also a 2nd commit in this PR that I think fixes a logic error: 64277b5